Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1935933002: Fix source information positions for deserialized patched elements. (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix source information positions for deserialized patched elements. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/52b45145f0a52f9089e892b1b9de581192c7e428

Patch Set 1 #

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -66 lines) Patch
M pkg/compiler/lib/src/closure.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 3 chunks +12 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 4 chunks +13 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 5 chunks +44 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 4 chunks +8 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 7 chunks +10 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization_compilation_test.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-04-30 11:43:34 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 7 months ago (2016-05-02 17:10:06 UTC) #3
Johnni Winther
4 years, 7 months ago (2016-05-03 08:52:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
52b45145f0a52f9089e892b1b9de581192c7e428 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698