pkg/compiler/lib/src/serialization/equivalence.dart - Issue 1935933002: Fix source information positions for deserialized patched elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/serialization/equivalence.dart

Issue 1935933002: Fix source information positions for deserialized patched elements. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/task.dart ('k') | pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/serialization/equivalence.dart

diff --git a/pkg/compiler/lib/src/serialization/equivalence.dart b/pkg/compiler/lib/src/serialization/equivalence.dart

index 9b41db20fad43b44dd60d4d7550e2de3912fb6cb..969ef408d23cdb4b69b78e87b8ad5416fe3866e7 100644

--- a/pkg/compiler/lib/src/serialization/equivalence.dart

+++ b/pkg/compiler/lib/src/serialization/equivalence.dart

@@ -771,7 +771,9 @@ bool testResolvedAstEquivalence(

'node', resolvedAst1.node, resolvedAst2.node) &&

new NodeEquivalenceVisitor(strategy).testNodes(resolvedAst1, resolvedAst2,

'body', resolvedAst1.body, resolvedAst2.body) &&

- testTreeElementsEquivalence(resolvedAst1, resolvedAst2, strategy);

+ testTreeElementsEquivalence(resolvedAst1, resolvedAst2, strategy) &&

+ strategy.test(resolvedAst1, resolvedAst2, 'sourceUri',

+ resolvedAst1.sourceUri, resolvedAst2.sourceUri);

}

/// Tests the equivalence of the data stored in the [TreeElements] of