Issue 193593002: Revert 256067 "Merge 255714 "Fixes bug that resulted in status b..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193593002: Revert 256067 "Merge 255714 "Fixes bug that resulted in status b..." (Closed)

Created:
6 years, 9 months ago by sky

Modified:
6 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+views_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1847/src/

Visibility:
Public.

More Reviews

Description

Revert 256067 "Merge 255714 "Fixes bug that resulted in status b..." > Merge 255714 "Fixes bug that resulted in status bubble getting h..." > > > Fixes bug that resulted in status bubble getting hidden > > > > Interesting enough this was happening because of a focus bug. Turns > > out a FocusController associated with one DesktopNativeWidgetAura > > could attempt to focus an aura::Window in a different > > DesktopNativeWidgetAura. When this happened it would move the > > content_window on top of the status bar. > > > > We should only activate windows within the same root. > > > > BUG=345698 > > TEST=covered by unit test, see bug as well. > > R=ben@chromium.org > > > > Review URL: https://codereview.chromium.org/186733011 > > TBR=sky@chromium.org > > Review URL: https://codereview.chromium.org/190633014 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256071

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -68 lines)			Patch
M	ui/views/views.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_focus_rules.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_focus_rules.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
D	ui/views/widget/desktop_aura/desktop_focus_rules_unittest.cc	View	1 chunk	+0 lines, -58 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r256071.

Expand Messages | Collapse Messages