Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1935863002: mojo: Fix leveldb unittests by making fs::Directories cloneable. (Closed)

Created:
4 years, 7 months ago by Elliot Glaysher
Modified:
4 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Fix leveldb unittests by making fs::Directories cloneable. This adds a Clone() method to mojo filesystem Directory objects, along with making it safe to clone Directory objects that represent temporary directories so that the temporary directory sticks around as long as there's a single open File or Directory referencing it. Using this, we can fix the last flaky LevelDBServiceTest that needed to access the filesystem. BUG=602820 Committed: https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796 Cr-Commit-Position: refs/heads/master@{#391040}

Patch Set 1 #

Patch Set 2 : Gyp continues to exist. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -30 lines) Patch
M components/filesystem/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/filesystem/directory_impl.h View 4 chunks +4 lines, -6 lines 0 comments Download
M components/filesystem/directory_impl.cc View 4 chunks +12 lines, -5 lines 0 comments Download
M components/filesystem/directory_impl_unittest.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M components/filesystem/file_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/filesystem/file_impl.cc View 4 chunks +7 lines, -1 line 0 comments Download
M components/filesystem/file_system_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/filesystem/file_system_impl.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M components/filesystem/filesystem.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/filesystem/public/interfaces/directory.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
A components/filesystem/shared_temp_dir.h View 1 chunk +33 lines, -0 lines 0 comments Download
A components/filesystem/shared_temp_dir.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M components/leveldb/leveldb_service_unittest.cc View 4 chunks +16 lines, -14 lines 0 comments Download
M services/user/user_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Elliot Glaysher
4 years, 7 months ago (2016-05-02 17:27:14 UTC) #2
jam
lgtm
4 years, 7 months ago (2016-05-02 19:04:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935863002/20001
4 years, 7 months ago (2016-05-02 19:05:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 20:13:54 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 20:15:14 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796
Cr-Commit-Position: refs/heads/master@{#391040}

Powered by Google App Engine
This is Rietveld 408576698