Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1707)

Unified Diff: components/filesystem/directory_impl.h

Issue 1935863002: mojo: Fix leveldb unittests by making fs::Directories cloneable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Gyp continues to exist. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/filesystem/BUILD.gn ('k') | components/filesystem/directory_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/filesystem/directory_impl.h
diff --git a/components/filesystem/directory_impl.h b/components/filesystem/directory_impl.h
index 6924271c89f2bac6daf116ac97c117011ffc0274..d88773a5ad143f96199396a57296217f594a01b0 100644
--- a/components/filesystem/directory_impl.h
+++ b/components/filesystem/directory_impl.h
@@ -13,13 +13,10 @@
#include "base/files/scoped_file.h"
#include "base/macros.h"
#include "components/filesystem/public/interfaces/directory.mojom.h"
+#include "components/filesystem/shared_temp_dir.h"
#include "mojo/public/cpp/bindings/interface_request.h"
#include "mojo/public/cpp/bindings/strong_binding.h"
-namespace base {
-class ScopedTempDir;
-} // namespace base
-
namespace filesystem {
class LockTable;
@@ -30,7 +27,7 @@ class DirectoryImpl : public Directory {
// when this object is destroyed.
DirectoryImpl(mojo::InterfaceRequest<Directory> request,
base::FilePath directory_path,
- std::unique_ptr<base::ScopedTempDir> temp_dir,
+ scoped_refptr<SharedTempDir> temp_dir,
scoped_refptr<LockTable> lock_table);
~DirectoryImpl() override;
@@ -64,6 +61,7 @@ class DirectoryImpl : public Directory {
void Flush(const FlushCallback& callback) override;
void StatFile(const mojo::String& path,
const StatFileCallback& callback) override;
+ void Clone(mojo::InterfaceRequest<Directory> directory) override;
void ReadEntireFile(const mojo::String& path,
const ReadEntireFileCallback& callback) override;
void WriteFile(const mojo::String& path,
@@ -73,7 +71,7 @@ class DirectoryImpl : public Directory {
private:
mojo::StrongBinding<Directory> binding_;
base::FilePath directory_path_;
- std::unique_ptr<base::ScopedTempDir> temp_dir_;
+ scoped_refptr<SharedTempDir> temp_dir_;
scoped_refptr<LockTable> lock_table_;
DISALLOW_COPY_AND_ASSIGN(DirectoryImpl);
« no previous file with comments | « components/filesystem/BUILD.gn ('k') | components/filesystem/directory_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698