Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1935793002: Fix lint bugs. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix lint bugs. Also fix typos and overrides. Committed: https://pdfium.googlesource.com/pdfium/+/fbe14b97f00b866e69e0970881550f6d6d9465cd

Patch Set 1 #

Patch Set 2 : override #

Total comments: 2

Patch Set 3 : fix lint false positive #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -209 lines) Patch
M fpdfsdk/javascript/JS_Define.h View 1 2 3 chunks +13 lines, -16 lines 0 comments Download
M xfa/fwl/basewidget/fxmath_barcodeimp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fxmath_barcodeimp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxbarcode/BC_BufferedImageLuminanceSource.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxbarcode/cbc_codabar.h View 1 chunk +9 lines, -5 lines 0 comments Download
M xfa/fxbarcode/cbc_codabar.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_code128.h View 1 chunk +11 lines, -7 lines 0 comments Download
M xfa/fxbarcode/cbc_code128.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_code39.h View 1 1 chunk +15 lines, -10 lines 0 comments Download
M xfa/fxbarcode/cbc_code39.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_codebase.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxbarcode/cbc_datamatrix.h View 1 1 chunk +15 lines, -11 lines 0 comments Download
M xfa/fxbarcode/cbc_datamatrix.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_ean13.h View 1 1 chunk +15 lines, -11 lines 0 comments Download
M xfa/fxbarcode/cbc_ean13.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_ean8.h View 1 1 chunk +15 lines, -11 lines 0 comments Download
M xfa/fxbarcode/cbc_ean8.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_onecode.h View 1 1 chunk +1 line, -18 lines 0 comments Download
M xfa/fxbarcode/cbc_pdf417i.h View 1 1 chunk +15 lines, -11 lines 0 comments Download
M xfa/fxbarcode/cbc_pdf417i.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_qrcode.h View 1 1 chunk +15 lines, -11 lines 0 comments Download
M xfa/fxbarcode/cbc_qrcode.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_upca.h View 1 1 chunk +15 lines, -8 lines 0 comments Download
M xfa/fxbarcode/cbc_upca.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedUPCAReader.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRCoderFormatInformation.h View 1 chunk +10 lines, -12 lines 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRCoderFormatInformation.cpp View 3 chunks +56 lines, -41 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Lei Zhang
4 years, 7 months ago (2016-04-29 22:07:34 UTC) #3
Tom Sepez
Otherwise fine. https://codereview.chromium.org/1935793002/diff/20001/fpdfsdk/javascript/JS_Define.h File fpdfsdk/javascript/JS_Define.h (right): https://codereview.chromium.org/1935793002/diff/20001/fpdfsdk/javascript/JS_Define.h#newcode10 fpdfsdk/javascript/JS_Define.h:10: #include <string> Shouldn't be necessary, as there ...
4 years, 7 months ago (2016-04-29 22:29:25 UTC) #4
Lei Zhang
https://codereview.chromium.org/1935793002/diff/20001/fpdfsdk/javascript/JS_Define.h File fpdfsdk/javascript/JS_Define.h (right): https://codereview.chromium.org/1935793002/diff/20001/fpdfsdk/javascript/JS_Define.h#newcode10 fpdfsdk/javascript/JS_Define.h:10: #include <string> On 2016/04/29 22:29:25, Tom Sepez wrote: > ...
4 years, 7 months ago (2016-04-30 01:22:49 UTC) #5
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-02 15:56:12 UTC) #6
Tom Sepez
On 2016/05/02 15:56:12, Tom Sepez wrote: > lgtm See also https://bugs.chromium.org/p/pdfium/issues/detail?id=488
4 years, 7 months ago (2016-05-02 15:59:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935793002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935793002/60001
4 years, 7 months ago (2016-05-02 20:18:00 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 20:31:13 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/fbe14b97f00b866e69e0970881550f6d6d94...

Powered by Google App Engine
This is Rietveld 408576698