WasAbortedInForeground: condition missing

chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
index dc2349a65ae2f3a2743c8650e40289a1f66aeff0..12287f6e72813bb3bb55189b88f3cf2262847582 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
@@ -175,6 +175,8 @@ bool WasAbortedInForeground(UserAbortType abort_type,
     return false;
   if (WasStartedInForegroundEventInForeground(time_to_abort, info))

[Charlie Harrison, 2016/04/29 21:02:36]

Doesn't WasStartedInForegroundEventInForeground check this?

[shivanisha, 2016/04/29 21:06:14]

It does and it returns false if info.started_in_foreground is false.
Before the new condition the code would have proceeded assuming
first_background_time exists which is not the case.

     return true;
+  if (!info.started_in_foreground)
+    return false;
   DCHECK_GT(time_to_abort, info.first_background_time);
   base::TimeDelta bg_abort_delta = time_to_abort - info.first_background_time;
   // Consider this a foregrounded abort if it occurred within 100ms of a