Fix Vulkan Build in Android

Fix Vulkan Build in Android

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1935523002

Committed: https://skia.googlesource.com/skia/+/b138fdc65f91d20e423d447e458cee2cdbf3ca3a

[liyuqian, 2016-04-29 14:52:58]

Description was changed from

==========
Fix Vulkan Build in Android

BUG=skia:
==========

to

==========
Fix Vulkan Build in Android

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[liyuqian, 2016-04-29 14:55:52]

Description was changed from

==========
Fix Vulkan Build in Android

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix Vulkan Build in Android

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[liyuqian, 2016-04-29 14:55:52]

liyuqian@google.com changed reviewers:
+ djsollen@google.com, jvanverth@google.com

[liyuqian, 2016-04-29 14:56:31]

This is Jim's patch to allow Vulkan to build in Android.

[djsollen, 2016-04-29 15:17:58]

+1 but I'll defer to jim on the vulkan context stuff.

[jvanverth1, 2016-04-29 15:25:12]

https://codereview.chromium.org/1935523002/diff/1/platform_tools/android/apps...
File
platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.cpp
(left):

https://codereview.chromium.org/1935523002/diff/1/platform_tools/android/apps...
platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.cpp:64:
bool SkOSWindow::attach(SkBackEndTypes /* attachType */, int
/*msaaSampleCount*/, AttachmentInfo* info)
I don't think this should be removed -- it's not part of the new framework.

https://codereview.chromium.org/1935523002/diff/1/platform_tools/android/apps...
File
platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp
(left):

https://codereview.chromium.org/1935523002/diff/1/platform_tools/android/apps...
platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp:26:
AttachmentInfo* info) {
Same here.

[liyuqian, 2016-04-29 15:32:08]

Thank you Jim! I've reverted the two unnecessary changes according to your
comments. Please let me know if there are more issues, and how I can test them
locally before sending another cl to bother you again :)

[jvanverth1, 2016-04-29 15:42:32]

On 2016/04/29 15:32:08, liyuqian wrote:
> Thank you Jim! I've reverted the two unnecessary changes according to your
> comments. Please let me know if there are more issues, and how I can test them
> locally before sending another cl to bother you again :)

You can kick off some trybots to see if it will compile properly on various
platforms. I did so for you already, but in the future you can click on where it
says "Choose trybots" and search for the ones you need. There are also trybots
that run unit tests, which can be helpful.

[jvanverth1, 2016-04-29 16:37:39]

Oh, and lgtm. :)

[liyuqian, 2016-04-29 16:43:45]

The CQ bit was checked by liyuqian@google.com

[commit-bot: I haz the power, 2016-04-29 16:43:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1935523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1935523002/20001

[commit-bot: I haz the power, 2016-04-29 17:00:28]

Description was changed from

==========
Fix Vulkan Build in Android

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix Vulkan Build in Android

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b138fdc65f91d20e423d447e458cee2cdbf3ca3a
==========

[commit-bot: I haz the power, 2016-04-29 17:00:29]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b138fdc65f91d20e423d447e458cee2cdbf3ca3a