Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1935273002: MD User Manager: Style fixes for User pods page (Closed)

Created:
4 years, 7 months ago by Moe
Modified:
4 years, 7 months ago
Reviewers:
tommycli, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@md-user-manager-refactor-css
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD User Manager: Style fixes for User pods page -user pod shadow when focused. -user pod re-auth warning. -unnecessary scrollbar in user pods page. BUG=563722, 607845 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1fd58222066ad3bbc6112f6c29960b7635a373bf Cr-Commit-Position: refs/heads/master@{#391521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M chrome/browser/resources/md_user_manager/user_manager_styles.html View 5 chunks +6 lines, -15 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
Moe
Tommy, Please review this patch. Thanks!
4 years, 7 months ago (2016-05-02 21:47:25 UTC) #4
tommycli
lgtm
4 years, 7 months ago (2016-05-03 16:55:41 UTC) #6
Moe
Thank you Tommy. Michael, Please review this CL. Thank you!
4 years, 7 months ago (2016-05-03 20:45:45 UTC) #9
michaelpg
lgtm
4 years, 7 months ago (2016-05-04 02:10:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935273002/1
4 years, 7 months ago (2016-05-04 13:57:52 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 15:54:25 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 15:56:13 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fd58222066ad3bbc6112f6c29960b7635a373bf
Cr-Commit-Position: refs/heads/master@{#391521}

Powered by Google App Engine
This is Rietveld 408576698