Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1940923003: MD User Manager: Refactoring CSS (Closed)

Created:
4 years, 7 months ago by Moe
Modified:
4 years, 7 months ago
Reviewers:
tommycli, dpapad
CC:
arv+watch_chromium.org, chromium-reviews, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@md-user-manager-design-change
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD User Manager: Refactoring CSS It also fixes the bug where bottom action bar was collapsing causing chrome logo to appear chopped. BUG=563722, 604326 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3ab3e7f364e801f9b12c81e23a202ef32e822660 Cr-Commit-Position: refs/heads/master@{#391488}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -121 lines) Patch
M chrome/browser/resources/md_user_manager/control_bar.html View 2 chunks +5 lines, -18 lines 0 comments Download
M chrome/browser/resources/md_user_manager/create_profile.html View 1 2 6 chunks +7 lines, -33 lines 0 comments Download
M chrome/browser/resources/md_user_manager/import_supervised_user.html View 3 chunks +5 lines, -26 lines 0 comments Download
M chrome/browser/resources/md_user_manager/shared_styles.html View 1 chunk +50 lines, -1 line 0 comments Download
M chrome/browser/resources/md_user_manager/supervised_user_create_confirm.html View 4 chunks +6 lines, -24 lines 0 comments Download
M chrome/browser/resources/md_user_manager/supervised_user_learn_more.html View 4 chunks +4 lines, -18 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_tutorial.html View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (11 generated)
Moe
Tommy, please review this patch. Thank you.
4 years, 7 months ago (2016-05-02 21:12:03 UTC) #4
tommycli
lgtm good refactor
4 years, 7 months ago (2016-05-02 22:10:55 UTC) #5
Moe
Thanks tommy. Demetrios, please take a look at this patch.
4 years, 7 months ago (2016-05-03 15:19:16 UTC) #7
dpapad
LGTM with question. https://codereview.chromium.org/1940923003/diff/1/chrome/browser/resources/md_user_manager/create_profile.html File chrome/browser/resources/md_user_manager/create_profile.html (right): https://codereview.chromium.org/1940923003/diff/1/chrome/browser/resources/md_user_manager/create_profile.html#newcode167 chrome/browser/resources/md_user_manager/create_profile.html:167: <template is="dom-repeat" items="[[availableIconUrls_]]"> Indentation seems off ...
4 years, 7 months ago (2016-05-03 17:48:58 UTC) #8
Moe
you're correct! "#wrapper" isn't needed here. It was left here from an older version of ...
4 years, 7 months ago (2016-05-03 18:57:53 UTC) #9
Moe
Thank you!
4 years, 7 months ago (2016-05-03 18:58:12 UTC) #10
commit-bot: I haz the power
This CL has an open dependency (Issue 1939933002 Patch 120001). Please resolve the dependency and ...
4 years, 7 months ago (2016-05-03 23:02:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940923003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940923003/40001
4 years, 7 months ago (2016-05-04 12:21:15 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-04 13:12:53 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 13:15:51 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3ab3e7f364e801f9b12c81e23a202ef32e822660
Cr-Commit-Position: refs/heads/master@{#391488}

Powered by Google App Engine
This is Rietveld 408576698