Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 19351003: Use toSVGMarkerElement() instead of static_cast<> (Closed)

Created:
7 years, 5 months ago by gyuyoung-inactive
Modified:
7 years, 5 months ago
Reviewers:
tkent, Stephen Chennney
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use toSVGMarkerElement() instead of static_cast<> Though there is toSVGMarkerElement(), some files still use static_cast<SVGMarkerElement*>. To remove all static_cast<> use, we need to change argument from SVGElement to Node. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154461

Patch Set 1 : #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M Source/core/rendering/svg/RenderSVGResourceMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMarker.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gyuyoung-inactive
Add tkent as reviewer.
7 years, 5 months ago (2013-07-16 09:29:58 UTC) #1
Stephen Chennney
lgtm
7 years, 5 months ago (2013-07-16 17:27:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19351003/1001
7 years, 5 months ago (2013-07-16 17:28:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=17115
7 years, 5 months ago (2013-07-16 20:13:02 UTC) #4
pdr.
@gyuyoung, I'm worried that we're heading in the wrong direction by continuing to land these ...
7 years, 5 months ago (2013-07-16 23:32:41 UTC) #5
tkent
On 2013/07/16 23:32:41, pdr wrote: > @gyuyoung, I'm worried that we're heading in the wrong ...
7 years, 5 months ago (2013-07-16 23:37:04 UTC) #6
pdr.
On 2013/07/16 23:37:04, tkent wrote: > On 2013/07/16 23:32:41, pdr wrote: > > @gyuyoung, I'm ...
7 years, 5 months ago (2013-07-16 23:39:51 UTC) #7
gyuyoung-inactive
On 2013/07/16 23:39:51, pdr wrote: > On 2013/07/16 23:37:04, tkent wrote: > > On 2013/07/16 ...
7 years, 5 months ago (2013-07-17 01:24:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19351003/21001
7 years, 5 months ago (2013-07-18 02:21:33 UTC) #9
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 03:15:33 UTC) #10
Message was sent while issue was closed.
Change committed as 154461

Powered by Google App Engine
This is Rietveld 408576698