gfx::Screen: Replace GetWindowUnderCursor() with IsWindowUnderCursor().

gfx::Screen: Replace GetWindowUnderCursor() with IsWindowUnderCursor().

This changes the interface to prevent handing handles to arbitrary
windows to Screen callers, as this is impossible in mus. Thankfully, all
callers were using this method as a way to check whether the mouse
cursor was within a specific window, which we can easily transform the
current implementations to.

BUG=602727
Committed: https://crrev.com/52ae866e32364d3463569cc9f896024d2889a7f7
Cr-Commit-Position: refs/heads/master@{#391273}

[Elliot Glaysher, 2016-05-02 20:49:13]

Description was changed from

==========
gfx::Screen: Replace GetWindowUnderCursor() with IsWindowUnderCursor().

This changes the interface to prevent handing handles to arbitrary
windows to Screen callers, as this is impossible in mus. Thankfully, all
callers were using this method as a way to check whether the mouse
cursor was within a specific window, which we can easily transform the
current implementations to.

BUG=
==========

to

==========
gfx::Screen: Replace GetWindowUnderCursor() with IsWindowUnderCursor().

This changes the interface to prevent handing handles to arbitrary
windows to Screen callers, as this is impossible in mus. Thankfully, all
callers were using this method as a way to check whether the mouse
cursor was within a specific window, which we can easily transform the
current implementations to.

BUG=602727
==========

[Elliot Glaysher, 2016-05-02 22:30:21]

erg@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-05-02 23:01:44]

I tend to think you should allow null in the new function but always return
false if null is supplied.

https://codereview.chromium.org/1935083003/diff/20001/ui/views/controls/menu/...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/1935083003/diff/20001/ui/views/controls/menu/...
ui/views/controls/menu/menu_controller.cc:1448:
IsWindowUnderCursor(owner_->GetNativeWindow());
This crashes if owner_ is null.

https://codereview.chromium.org/1935083003/diff/20001/ui/views/mus/screen_mus.cc
File ui/views/mus/screen_mus.cc (right):

https://codereview.chromium.org/1935083003/diff/20001/ui/views/mus/screen_mus...
ui/views/mus/screen_mus.cc:178: return
window->GetBoundsInScreen().Contains(GetCursorScreenPoint());
I think you should check drawn here too.

[Elliot Glaysher, 2016-05-02 23:17:51]

Check null in two places, and check visibility too.

[sky, 2016-05-02 23:59:37]

LGTM with the following

https://codereview.chromium.org/1935083003/diff/40001/ui/views/mus/screen_mus.cc
File ui/views/mus/screen_mus.cc (right):

https://codereview.chromium.org/1935083003/diff/40001/ui/views/mus/screen_mus...
ui/views/mus/screen_mus.cc:181: return window->IsVisible() &&
IsVisible->IsDrawn

[sky, 2016-05-03 00:02:48]

LGTM

https://codereview.chromium.org/1935083003/diff/40001/ui/views/mus/screen_mus.cc
File ui/views/mus/screen_mus.cc (right):

https://codereview.chromium.org/1935083003/diff/40001/ui/views/mus/screen_mus...
ui/views/mus/screen_mus.cc:181: return window->IsVisible() &&
On 2016/05/02 23:59:37, sky wrote:
> IsVisible->IsDrawn

D'OH. IsVisible is what you want. Sorry.

[Elliot Glaysher, 2016-05-03 00:03:22]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2016-05-03 00:04:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1935083003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1935083003/40001

[commit-bot: I haz the power, 2016-05-03 00:11:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 00:11:27]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Elliot Glaysher, 2016-05-03 00:13:19]

erg@chromium.org changed reviewers:
+ brettw@chromium.org

[Elliot Glaysher, 2016-05-03 00:13:20]

+brettw for toplevel owners stamp

https://codereview.chromium.org/1935083003/diff/40001/ui/views/mus/screen_mus.cc
File ui/views/mus/screen_mus.cc (right):

https://codereview.chromium.org/1935083003/diff/40001/ui/views/mus/screen_mus...
ui/views/mus/screen_mus.cc:181: return window->IsVisible() &&
On 2016/05/02 23:59:37, sky wrote:
> IsVisible->IsDrawn

As discussed in person, this is an aura window, not a mus window. Leaving as is.

[brettw, 2016-05-03 16:59:12]

lgtm

[Elliot Glaysher, 2016-05-03 17:05:44]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2016-05-03 17:06:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1935083003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1935083003/40001

[commit-bot: I haz the power, 2016-05-03 17:11:48]

Description was changed from

==========
gfx::Screen: Replace GetWindowUnderCursor() with IsWindowUnderCursor().

This changes the interface to prevent handing handles to arbitrary
windows to Screen callers, as this is impossible in mus. Thankfully, all
callers were using this method as a way to check whether the mouse
cursor was within a specific window, which we can easily transform the
current implementations to.

BUG=602727
==========

to

==========
gfx::Screen: Replace GetWindowUnderCursor() with IsWindowUnderCursor().

This changes the interface to prevent handing handles to arbitrary
windows to Screen callers, as this is impossible in mus. Thankfully, all
callers were using this method as a way to check whether the mouse
cursor was within a specific window, which we can easily transform the
current implementations to.

BUG=602727
==========

[commit-bot: I haz the power, 2016-05-03 17:11:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-03 17:13:52]

Description was changed from

==========
gfx::Screen: Replace GetWindowUnderCursor() with IsWindowUnderCursor().

This changes the interface to prevent handing handles to arbitrary
windows to Screen callers, as this is impossible in mus. Thankfully, all
callers were using this method as a way to check whether the mouse
cursor was within a specific window, which we can easily transform the
current implementations to.

BUG=602727
==========

to

==========
gfx::Screen: Replace GetWindowUnderCursor() with IsWindowUnderCursor().

This changes the interface to prevent handing handles to arbitrary
windows to Screen callers, as this is impossible in mus. Thankfully, all
callers were using this method as a way to check whether the mouse
cursor was within a specific window, which we can easily transform the
current implementations to.

BUG=602727

Committed: https://crrev.com/52ae866e32364d3463569cc9f896024d2889a7f7
Cr-Commit-Position: refs/heads/master@{#391273}
==========

[commit-bot: I haz the power, 2016-05-03 17:13:54]

Patchset 3 (id:??) landed as
https://crrev.com/52ae866e32364d3463569cc9f896024d2889a7f7
Cr-Commit-Position: refs/heads/master@{#391273}