Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1935043002: Avoid style recalc and layout when not necessary for client size. (Closed)

Created:
4 years, 7 months ago by rune
Modified:
4 years, 7 months ago
Reviewers:
esprehn, Rick Byers
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid style recalc and layout when not necessary for client size. The clientWidth and clientHeight values do not rely on style recalc for the documentElement in strict mode, and the body element in quirks mode when we use overlay scrollbars. Skip the forced layout update in those cases. BUG=481412 Committed: https://crrev.com/b87800cbc5af30ef4fad30f874121702c857b753 Cr-Commit-Position: refs/heads/master@{#391187}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Skip layout for local frame roots only #

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935043002/1
4 years, 7 months ago (2016-05-02 14:05:38 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-02 15:33:36 UTC) #4
rune
4 years, 7 months ago (2016-05-02 18:25:20 UTC) #6
esprehn
This is only correct it you're the top level document I think. Your patch would ...
4 years, 7 months ago (2016-05-02 19:02:12 UTC) #7
rune
On 2016/05/02 19:02:12, esprehn wrote: > This is only correct it you're the top level ...
4 years, 7 months ago (2016-05-02 22:48:12 UTC) #8
rune
https://codereview.chromium.org/1935043002/diff/1/third_party/WebKit/LayoutTests/fast/dom/body-quirk-client-size.html File third_party/WebKit/LayoutTests/fast/dom/body-quirk-client-size.html (right): https://codereview.chromium.org/1935043002/diff/1/third_party/WebKit/LayoutTests/fast/dom/body-quirk-client-size.html#newcode1 third_party/WebKit/LayoutTests/fast/dom/body-quirk-client-size.html:1: <script src="../../resources/js-test.js"></script> On 2016/05/02 19:02:12, esprehn wrote: > Can ...
4 years, 7 months ago (2016-05-02 22:48:22 UTC) #9
esprehn
lgtm
4 years, 7 months ago (2016-05-03 03:03:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935043002/20001
4 years, 7 months ago (2016-05-03 06:14:58 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/64066)
4 years, 7 months ago (2016-05-03 08:09:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935043002/20001
4 years, 7 months ago (2016-05-03 08:20:29 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 09:22:11 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 09:23:40 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b87800cbc5af30ef4fad30f874121702c857b753
Cr-Commit-Position: refs/heads/master@{#391187}

Powered by Google App Engine
This is Rietveld 408576698