third_party/WebKit/LayoutTests/fast/dom/root-client-size.html - Issue 1935043002: Avoid style recalc and layout when not necessary for client size.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/root-client-size.html

Issue 1935043002: Avoid style recalc and layout when not necessary for client size. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Skip layout for local frame roots only Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/body-quirk-client-size-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/dom/root-client-size-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <style>

	4 :root { width: 100%; height: 100% }

	5 #container.wide { width: 5000px; height: 10px; }

	6 #container.tall { height: 5000px; width: 10px; }

	7 </style>

	8 <div id="container"></div>

	9 <script>

	10 description("Style recalc when reading clientWidth/clientHeight of documentE lement in strict mode.");

	11

	12 shouldBeDefined(window.internals);

	13

	14 function runClientSizeTest(testClass, expectWidthChange, expectHeightChange, expectedRecalcCount) {

	15

	16 var origWidth = document.documentElement.clientWidth;

	17 var origHeight = document.documentElement.clientHeight;

	18 internals.updateStyleAndReturnAffectedElementCount();

	19

	20 container.classList.add(testClass)

	21

	22 var afterWidth = document.documentElement.clientWidth;

	23 var afterHeight = document.documentElement.clientHeight;

	24

	25 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", ""+expe ctedRecalcCount);

	26

	27 if (expectWidthChange)

	28 shouldBeGreaterThan(""+origWidth, ""+afterWidth);

	29 else

	30 shouldBe(""+origWidth, ""+afterWidth);

	31

	32 if (expectHeightChange)

	33 shouldBeGreaterThan(""+origHeight, ""+afterHeight);

	34 else

	35 shouldBe(""+origHeight, ""+afterHeight);

	36

	37 container.classList.remove(testClass)

	38 }

	39

	40 var originalOverlayScrollbars = internals.runtimeFlags.overlayScrollbarsEnab led;

	41

	42 internals.settings.setOverlayScrollbarsEnabled(true);

	43

	44 runClientSizeTest("wide", false, false, 1);

	45 runClientSizeTest("tall", false, false, 1);

	46

	47 internals.settings.setOverlayScrollbarsEnabled(false);

	48

	49 runClientSizeTest("wide", false, true, 0);

	50 runClientSizeTest("tall", true, false, 0);

	51

	52 internals.settings.setOverlayScrollbarsEnabled(originalOverlayScrollbars);

	53 </script>

OLD	NEW