Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1935023002: Relax the conditions to show the permanent notice about other forms of browsing history (Closed)

Created:
4 years, 7 months ago by msramek
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Relax the conditions to show the permanent notice about other forms of browsing history The notice in the Clear Browsing Data dialog footer and history page header will now not require WebHistoryService::HasOtherFormsOfBrowsingHistory() to be true. However, showing the one-time notice in the Clear Browsing Data dialog still will. BUG=607155 Review-Url: https://codereview.chromium.org/1915983007 Cr-Commit-Position: refs/heads/master@{#390607} (cherry picked from commit 2908c2ef968baf62cef0a45c87031e145c3ea39e) Committed: https://chromium.googlesource.com/chromium/src/+/415badb4264d0080e2956a257bb1ecc8c357e091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M components/browsing_data_ui/history_notice_utils.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
msramek
4 years, 7 months ago (2016-05-02 13:24:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
415badb4264d0080e2956a257bb1ecc8c357e091.

Powered by Google App Engine
This is Rietveld 408576698