Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 1915983007: Relax the conditions to show the permanent notice about other forms of browsing history (Closed)

Created:
4 years, 7 months ago by msramek
Modified:
4 years, 7 months ago
Reviewers:
battre
CC:
chromium-reviews, msarda
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relax the conditions to show the permanent notice about other forms of browsing history The notice in the Clear Browsing Data dialog footer and history page header will now not require WebHistoryService::HasOtherFormsOfBrowsingHistory() to be true. However, showing the one-time notice in the Clear Browsing Data dialog still will. BUG=607155 Committed: https://crrev.com/2908c2ef968baf62cef0a45c87031e145c3ea39e Cr-Commit-Position: refs/heads/master@{#390607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M components/browsing_data_ui/history_notice_utils.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
msramek
Hi Dominic, can you please take a look? Thanks, Martin
4 years, 7 months ago (2016-04-27 13:27:29 UTC) #2
battre
lgtm
4 years, 7 months ago (2016-04-29 08:40:41 UTC) #3
msramek
Thanks!
4 years, 7 months ago (2016-04-29 08:42:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915983007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915983007/1
4 years, 7 months ago (2016-04-29 08:42:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 09:35:44 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:24:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2908c2ef968baf62cef0a45c87031e145c3ea39e
Cr-Commit-Position: refs/heads/master@{#390607}

Powered by Google App Engine
This is Rietveld 408576698