Issue 1934863002: Revert of Don't assert rect mapping result if impossible, and enable assert in debug build

Issue 1934863002: Revert of Don't assert rect mapping result if impossible, and enable assert in debug build (Closed)

Created:
4 years, 7 months ago by Dirk Pranke

Modified:
4 years, 7 months ago

Reviewers:
chrishtr, Xianzhu

CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/src.git@SVGRootClip

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Don't assert rect mapping result if impossible, and enable assert in debug build (patchset #15 id:280001 of https://codereview.chromium.org/1859833002/ ) Reason for revert: I think this probably broke one of the telemetry benchmarks (which looks like it's hitting a crash inside blink now): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/48270 https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/23432 Original issue's description: > Don't assert rect mapping result if impossible, and enable assert in debug build > > Avoid rect mapping result checking in the following cases: > - Any rect may contain saturated values; > - If a fixed-position ancestor disabled clipping. > > BUG=591199 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_dbg,mac_blink_dbg,win_blink_dbg TBR=chrishtr@chromium.org,wangxianzhu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591199 Committed: https://crrev.com/004517dc7be6643dcdf55009cf6a8b868ad7334e Cr-Commit-Position: refs/heads/master@{#390834}

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -79 lines)			Patch
M	third_party/WebKit/Source/core/layout/LayoutView.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/PaintInvalidationState.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp	View	9 chunks	+53 lines, -73 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Dirk Pranke

Created Revert of Don't assert rect mapping result if impossible, and enable assert in debug ...

4 years, 7 months ago (2016-04-30 01:47:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934863002/1

4 years, 7 months ago (2016-04-30 01:48:04 UTC) #2

commit-bot: I haz the power

Description was changed from ========== Revert of Don't assert rect mapping result if impossible, and ...

4 years, 7 months ago (2016-04-30 01:48:41 UTC) #3

Message was sent while issue was closed.

Description was changed from

==========
Revert of Don't assert rect mapping result if impossible, and enable assert in
debug build (patchset #15 id:280001 of
https://codereview.chromium.org/1859833002/ )

Reason for revert:
I think this probably broke one of the telemetry benchmarks (which looks like
it's hitting a crash inside blink now):

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2...

Original issue's description:
> Don't assert rect mapping result if impossible, and enable assert in debug
build
> 
> Avoid rect mapping result checking in the following cases:
> - Any rect may contain saturated values;
> - If a fixed-position ancestor disabled clipping.
> 
> BUG=591199
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_dbg,mac_blink_dbg,win_blink_dbg

TBR=chrishtr@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591199
==========

to

==========
Revert of Don't assert rect mapping result if impossible, and enable assert in
debug build (patchset #15 id:280001 of
https://codereview.chromium.org/1859833002/ )

Reason for revert:
I think this probably broke one of the telemetry benchmarks (which looks like
it's hitting a crash inside blink now):

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2...

Original issue's description:
> Don't assert rect mapping result if impossible, and enable assert in debug
build
> 
> Avoid rect mapping result checking in the following cases:
> - Any rect may contain saturated values;
> - If a fixed-position ancestor disabled clipping.
> 
> BUG=591199
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_dbg,mac_blink_dbg,win_blink_dbg

TBR=chrishtr@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591199
==========

commit-bot: I haz the power

4 years, 7 months ago (2016-04-30 17:30:55 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/004517dc7be6643dcdf55009cf6a8b868ad7334e
Cr-Commit-Position: refs/heads/master@{#390834}

commit-bot: I haz the power

4 years, 7 months ago (2016-04-30 18:03:58 UTC) #6

Message was sent while issue was closed.

Description was changed from

==========
Revert of Don't assert rect mapping result if impossible, and enable assert in
debug build (patchset #15 id:280001 of
https://codereview.chromium.org/1859833002/ )

Reason for revert:
I think this probably broke one of the telemetry benchmarks (which looks like
it's hitting a crash inside blink now):

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2...

Original issue's description:
> Don't assert rect mapping result if impossible, and enable assert in debug
build
> 
> Avoid rect mapping result checking in the following cases:
> - Any rect may contain saturated values;
> - If a fixed-position ancestor disabled clipping.
> 
> BUG=591199
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_dbg,mac_blink_dbg,win_blink_dbg

TBR=chrishtr@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591199
==========

to

==========
Revert of Don't assert rect mapping result if impossible, and enable assert in
debug build (patchset #15 id:280001 of
https://codereview.chromium.org/1859833002/ )

Reason for revert:
I think this probably broke one of the telemetry benchmarks (which looks like
it's hitting a crash inside blink now):

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2...

Original issue's description:
> Don't assert rect mapping result if impossible, and enable assert in debug
build
>
> Avoid rect mapping result checking in the following cases:
> - Any rect may contain saturated values;
> - If a fixed-position ancestor disabled clipping.
>
> BUG=591199
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_dbg,mac_blink_dbg,win_blink_dbg

TBR=chrishtr@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591199

Committed: https://crrev.com/004517dc7be6643dcdf55009cf6a8b868ad7334e
Cr-Commit-Position: refs/heads/master@{#390834}
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages