Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 1934863002: Revert of Don't assert rect mapping result if impossible, and enable assert in debug build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SVGRootClip
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/PaintInvalidationState.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 468 matching lines...) Expand 10 before | Expand all | Expand 10 after
479 compositor()->fullyInvalidatePaint(); 479 compositor()->fullyInvalidatePaint();
480 } 480 }
481 481
482 bool LayoutView::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ance stor, LayoutRect& rect, VisualRectFlags visualRectFlags) const 482 bool LayoutView::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ance stor, LayoutRect& rect, VisualRectFlags visualRectFlags) const
483 { 483 {
484 return mapToVisualRectInAncestorSpace(ancestor, rect, 0, visualRectFlags); 484 return mapToVisualRectInAncestorSpace(ancestor, rect, 0, visualRectFlags);
485 } 485 }
486 486
487 bool LayoutView::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ance stor, LayoutRect& rect, MapCoordinatesFlags mode, VisualRectFlags visualRectFlag s) const 487 bool LayoutView::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ance stor, LayoutRect& rect, MapCoordinatesFlags mode, VisualRectFlags visualRectFlag s) const
488 { 488 {
489 if (document().printing())
490 return true;
491
489 // Convert the rect into the physical coordinates space of this LayoutView. 492 // Convert the rect into the physical coordinates space of this LayoutView.
490 flipForWritingMode(rect); 493 flipForWritingMode(rect);
491 494
492 if (mode & IsFixed) 495 if (mode & IsFixed)
493 adjustOffsetForFixedPosition(rect); 496 adjustOffsetForFixedPosition(rect);
494 497
495 // Apply our transform if we have one (because of full page zooming). 498 // Apply our transform if we have one (because of full page zooming).
496 if (!ancestor && layer() && layer()->transform()) 499 if (!ancestor && layer() && layer()->transform())
497 rect = layer()->transform()->mapRect(rect); 500 rect = layer()->transform()->mapRect(rect);
498 501
(...skipping 536 matching lines...) Expand 10 before | Expand all | Expand 10 after
1035 // ASSERT(!frame()->isMainFrame()) here. All main frame scrolling should 1038 // ASSERT(!frame()->isMainFrame()) here. All main frame scrolling should
1036 // be handled by the ViewportScrollCallback. 1039 // be handled by the ViewportScrollCallback.
1037 1040
1038 if (!frameView()) 1041 if (!frameView())
1039 return ScrollResult(false, false, delta.width(), delta.height()); 1042 return ScrollResult(false, false, delta.width(), delta.height());
1040 1043
1041 return frameView()->getScrollableArea()->userScroll(granularity, delta); 1044 return frameView()->getScrollableArea()->userScroll(granularity, delta);
1042 } 1045 }
1043 1046
1044 } // namespace blink 1047 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/PaintInvalidationState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698