Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1934813002: Skip checks of types for local elements, and duplicate them as top-level element tests. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip checks of types for local elements, and duplicate them as top-level element tests. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/79ba493ae3f3d08cd2949cde0928373b6d00674f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -74 lines) Patch
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 5 chunks +23 lines, -44 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 21 chunks +229 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 7 months ago (2016-04-29 22:29:36 UTC) #1
Paul Berry
4 years, 7 months ago (2016-04-29 23:55:49 UTC) #2
Paul Berry
lgtm
4 years, 7 months ago (2016-04-29 23:55:56 UTC) #3
scheglov
4 years, 7 months ago (2016-04-30 00:19:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
79ba493ae3f3d08cd2949cde0928373b6d00674f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698