Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_ast_test.dart

Issue 1934813002: Skip checks of types for local elements, and duplicate them as top-level element tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/task/strong/inferred_type_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart b/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
index 1bfac3724802e3f4070b24a1c921e1df871eda62..992cce5783889a33ffbe916b164107819827dad6 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
@@ -44,6 +44,9 @@ class AstInferredTypeTest extends AbstractResynthesizeTest
}
@override
+ bool get mayCheckTypesOfLocals => false;
+
+ @override
bool get skipBrokenAstInference => true;
@override
@@ -79,26 +82,26 @@ class AstInferredTypeTest extends AbstractResynthesizeTest
@override
@failingTest
- void test_blockBodiedLambdas_async_allReturnsAreValues() {
- super.test_blockBodiedLambdas_async_allReturnsAreValues();
+ void test_blockBodiedLambdas_async_allReturnsAreFutures_topLevel() {
+ super.test_blockBodiedLambdas_async_allReturnsAreFutures_topLevel();
}
@override
@failingTest
- void test_blockBodiedLambdas_async_alReturnsAreFutures() {
- super.test_blockBodiedLambdas_async_alReturnsAreFutures();
+ void test_blockBodiedLambdas_async_allReturnsAreValues_topLevel() {
+ super.test_blockBodiedLambdas_async_allReturnsAreValues_topLevel();
}
@override
@failingTest
- void test_blockBodiedLambdas_async_mixOfValuesAndFutures() {
- super.test_blockBodiedLambdas_async_mixOfValuesAndFutures();
+ void test_blockBodiedLambdas_async_mixOfValuesAndFutures_topLevel() {
+ super.test_blockBodiedLambdas_async_mixOfValuesAndFutures_topLevel();
}
@override
@failingTest
- void test_blockBodiedLambdas_asyncStar() {
- super.test_blockBodiedLambdas_asyncStar();
+ void test_blockBodiedLambdas_asyncStar_topLevel() {
+ super.test_blockBodiedLambdas_asyncStar_topLevel();
}
@override
@@ -109,32 +112,26 @@ class AstInferredTypeTest extends AbstractResynthesizeTest
@override
@failingTest
- void test_blockBodiedLambdas_doesNotInferBottom_async() {
- super.test_blockBodiedLambdas_doesNotInferBottom_async();
+ void test_blockBodiedLambdas_doesNotInferBottom_async_topLevel() {
+ super.test_blockBodiedLambdas_doesNotInferBottom_async_topLevel();
}
@override
@failingTest
- void test_blockBodiedLambdas_doesNotInferBottom_asyncStar() {
- super.test_blockBodiedLambdas_doesNotInferBottom_asyncStar();
+ void test_blockBodiedLambdas_doesNotInferBottom_asyncStar_topLevel() {
+ super.test_blockBodiedLambdas_doesNotInferBottom_asyncStar_topLevel();
}
@override
@failingTest
- void test_blockBodiedLambdas_doesNotInferBottom_sync() {
- super.test_blockBodiedLambdas_doesNotInferBottom_sync();
+ void test_blockBodiedLambdas_doesNotInferBottom_sync_topLevel() {
+ super.test_blockBodiedLambdas_doesNotInferBottom_sync_topLevel();
}
@override
@failingTest
- void test_blockBodiedLambdas_doesNotInferBottom_syncStar() {
- super.test_blockBodiedLambdas_doesNotInferBottom_syncStar();
- }
-
- @override
- @failingTest
- void test_blockBodiedLambdas_downwardsIncompatibleWithUpwardsInference() {
- super.test_blockBodiedLambdas_downwardsIncompatibleWithUpwardsInference();
+ void test_blockBodiedLambdas_doesNotInferBottom_syncStar_topLevel() {
+ super.test_blockBodiedLambdas_doesNotInferBottom_syncStar_topLevel();
}
@override
@@ -145,20 +142,14 @@ class AstInferredTypeTest extends AbstractResynthesizeTest
@override
@failingTest
- void test_blockBodiedLambdas_nestedLambdas() {
- super.test_blockBodiedLambdas_nestedLambdas();
- }
-
- @override
- @failingTest
- void test_blockBodiedLambdas_noReturn() {
- super.test_blockBodiedLambdas_noReturn();
+ void test_blockBodiedLambdas_nestedLambdas_topLevel() {
+ super.test_blockBodiedLambdas_nestedLambdas_topLevel();
}
@override
@failingTest
- void test_blockBodiedLambdas_syncStar() {
- super.test_blockBodiedLambdas_syncStar();
+ void test_blockBodiedLambdas_syncStar_topLevel() {
+ super.test_blockBodiedLambdas_syncStar_topLevel();
}
@override
@@ -620,18 +611,6 @@ var v = new C().m(1, b: 'bbb', c: 2.0);
@override
@failingTest
- void test_listLiteralsShouldNotInferBottom() {
- super.test_listLiteralsShouldNotInferBottom();
- }
-
- @override
- @failingTest
- void test_mapLiteralsShouldNotInferBottom() {
- super.test_mapLiteralsShouldNotInferBottom();
- }
-
- @override
- @failingTest
void test_nullLiteralShouldNotInferAsBottom() {
super.test_nullLiteralShouldNotInferAsBottom();
}
« no previous file with comments | « no previous file | pkg/analyzer/test/src/task/strong/inferred_type_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698