Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Fix tab focus change. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index fda2cf18b882eb4d26944e846320c49da4d61f82..92d2fef6b6015ac0cbc53ad97a90d239ec4e222a 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -415,6 +415,11 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost,
// cross-process window.focus() calls.
void SetFocusedFrame();
+ // Unset this frame as focused in the renderer process. This allows loss of
+ // focus inside an inner WebContents when focus in the embedder goes from that
+ // WebContents to another element in the embedder WebContents.
alexmos 2016/05/12 20:28:40 This sounded a bit ambiguous to me, do you mean "T
avallee 2016/05/16 20:26:43 Pretty good. Focus could also move to a sibling w
alexmos 2016/05/19 00:08:08 Acknowledged.
+ void UnsetFocusedFrame();
+
// Deletes the current selection plus the specified number of characters
// before and after the selection or caret.
void ExtendSelectionAndDelete(size_t before, size_t after);

Powered by Google App Engine
This is Rietveld 408576698