Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Fix tab focus change. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 9e15211fecddc2047ecbfd92bbe3600eccaa0524..9e1b8e590e75a21fe6e5db08ebd44edc63361ac5 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -859,7 +859,7 @@ void RenderFrameHostImpl::OnDetach() {
}
void RenderFrameHostImpl::OnFrameFocused() {
- frame_tree_->SetFocusedFrame(frame_tree_node_, GetSiteInstance());
+ delegate_->SetFocusedFrame(frame_tree_node_, GetSiteInstance());
}
void RenderFrameHostImpl::OnOpenURL(const FrameHostMsg_OpenURL_Params& params) {
@@ -2146,6 +2146,10 @@ void RenderFrameHostImpl::SetFocusedFrame() {
Send(new FrameMsg_SetFocusedFrame(routing_id_));
}
+void RenderFrameHostImpl::UnsetFocusedFrame() {
alexmos 2016/05/12 20:28:40 nit: naming this (and related bits) ClearFocusedFr
avallee 2016/05/16 20:26:43 Done.
+ Send(new FrameMsg_UnsetFocusedFrame(routing_id_));
+}
+
void RenderFrameHostImpl::ExtendSelectionAndDelete(size_t before,
size_t after) {
Send(new InputMsg_ExtendSelectionAndDelete(routing_id_, before, after));
@@ -2744,6 +2748,8 @@ void RenderFrameHostImpl::AXContentTreeDataToAXTreeData(
return;
// For the root frame tree node, also store the AXTreeID of the focused frame.
+ // TODO(avallee): https://crbug.com/610795 This is probably where we need to
+ // fix the bug to enable the test.
alexmos 2016/05/12 20:28:39 nit: explicitly mention that this code is problema
avallee 2016/05/16 20:26:43 Done.
FrameTreeNode* focused_frame_tree_node = frame_tree_->GetFocusedFrame();
if (!focused_frame_tree_node)
return;

Powered by Google App Engine
This is Rietveld 408576698