third_party/WebKit/Source/web/WebViewImpl.h - Issue 1934703002: Fix keyboard focus for OOPIF-<webview>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test flakiness and comments in PS 7,8. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.h

diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h

index 1b130a7368a06b6ecaefac789f3004d5baecac32..a28ccfe6da4f89d7c0c9280d47d8d5e754370e75 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.h

+++ b/third_party/WebKit/Source/web/WebViewImpl.h

@@ -187,6 +187,7 @@ public:

WebFrame* focusedFrame() override;

void setFocusedFrame(WebFrame*) override;

void focusDocumentView(WebFrame*) override;

+ void unfocusDocumentView(WebFrame*) override;

void setInitialFocus(bool reverse) override;

void clearFocusedElement() override;

bool scrollFocusedEditableElementIntoRect(const WebRect&) override;