Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test flakiness and comments in PS 7,8. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 void resizeWithTopControls( 180 void resizeWithTopControls(
181 const WebSize&, 181 const WebSize&,
182 float topControlsHeight, 182 float topControlsHeight,
183 bool topControlsShrinkLayout) override; 183 bool topControlsShrinkLayout) override;
184 WebFrame* mainFrame() override; 184 WebFrame* mainFrame() override;
185 WebFrame* findFrameByName( 185 WebFrame* findFrameByName(
186 const WebString& name, WebFrame* relativeToFrame) override; 186 const WebString& name, WebFrame* relativeToFrame) override;
187 WebFrame* focusedFrame() override; 187 WebFrame* focusedFrame() override;
188 void setFocusedFrame(WebFrame*) override; 188 void setFocusedFrame(WebFrame*) override;
189 void focusDocumentView(WebFrame*) override; 189 void focusDocumentView(WebFrame*) override;
190 void unfocusDocumentView(WebFrame*) override;
190 void setInitialFocus(bool reverse) override; 191 void setInitialFocus(bool reverse) override;
191 void clearFocusedElement() override; 192 void clearFocusedElement() override;
192 bool scrollFocusedEditableElementIntoRect(const WebRect&) override; 193 bool scrollFocusedEditableElementIntoRect(const WebRect&) override;
193 void smoothScroll(int targetX, int targetY, long durationMs) override; 194 void smoothScroll(int targetX, int targetY, long durationMs) override;
194 void zoomToFindInPageRect(const WebRect&); 195 void zoomToFindInPageRect(const WebRect&);
195 void advanceFocus(bool reverse) override; 196 void advanceFocus(bool reverse) override;
196 void advanceFocusAcrossFrames(WebFocusType, WebRemoteFrame* from, WebLocalFr ame* to) override; 197 void advanceFocusAcrossFrames(WebFocusType, WebRemoteFrame* from, WebLocalFr ame* to) override;
197 double zoomLevel() override; 198 double zoomLevel() override;
198 double setZoomLevel(double) override; 199 double setZoomLevel(double) override;
199 void zoomLimitsChanged(double minimumZoomLevel, double maximumZoomLevel) ove rride; 200 void zoomLimitsChanged(double minimumZoomLevel, double maximumZoomLevel) ove rride;
(...skipping 567 matching lines...) Expand 10 before | Expand all | Expand 10 after
767 double m_lastFrameTimeMonotonic; 768 double m_lastFrameTimeMonotonic;
768 }; 769 };
769 770
770 // We have no ways to check if the specified WebView is an instance of 771 // We have no ways to check if the specified WebView is an instance of
771 // WebViewImpl because WebViewImpl is the only implementation of WebView. 772 // WebViewImpl because WebViewImpl is the only implementation of WebView.
772 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 773 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
773 774
774 } // namespace blink 775 } // namespace blink
775 776
776 #endif 777 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698