Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ready for review: Fix works with oopif webview but does not fix crbug.com/609903 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index dbce5b06b65f7e4ff4ef9e4783670e765bcfada8..8093ad661bf2d45c016460ccb06a244cd0fe11f8 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -2901,6 +2901,14 @@ void WebViewImpl::focusDocumentView(WebFrame* frame)
page()->focusController().focusDocumentView(frame->toImplBase()->frame(), false /* notifyEmbedder */);
}
+void WebViewImpl::unfocusDocumentView(WebFrame* frame)
+{
+ if (page()->focusController().focusedFrame() == frame->toImplBase()->frame()) {
+ page()->focusController().focusDocumentView(nullptr /* frame */, false /* notifyEmbedder */);
+ }
+ // TODO(avallee): else NOTREACHED() ?
lfg 2016/05/06 21:23:33 No need for this.
dcheng 2016/05/09 18:25:08 Is there ever a case where we'll legitimately call
avallee 2016/05/11 18:26:11 I don't think so, unless the browser and renderer
avallee 2016/05/11 18:26:11 Done.
dcheng 2016/05/11 18:46:58 If this can never happen, why do we need the if (.
+}
+
void WebViewImpl::setInitialFocus(bool reverse)
{
if (!m_page)

Powered by Google App Engine
This is Rietveld 408576698