Fix keyboard focus for OOPIF-<webview>.

third_party/WebKit/Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 2883 matching lines @@
 
 void WebViewImpl::focusDocumentView(WebFrame* frame)
 {
     // This is currently only used when replicating focus changes for
     // cross-process frames, and |notifyEmbedder| is disabled to avoid sending
     // duplicate frameFocused updates from FocusController to the browser
     // process, which already knows the latest focused frame.
     page()->focusController().focusDocumentView(frame->toImplBase()->frame(), false /* notifyEmbedder */);
 }
 
+void WebViewImpl::unfocusDocumentView(WebFrame* frame)
+{
+    if (page()->focusController().focusedFrame() == frame->toImplBase()->frame()) {
+        page()->focusController().focusDocumentView(nullptr /* frame */, false /* notifyEmbedder */);
+    }
+    // TODO(avallee): else NOTREACHED() ?

[lfg, 2016/05/06 21:23:33]

No need for this.

[dcheng, 2016/05/09 18:25:08]

Is there ever a case where we'll legitimately call this when focusedFrame() !=
frame->toImplBase()->frame()? Seems like we should just assert.

[avallee, 2016/05/11 18:26:11]

I don't think so, unless the browser and renderer get out of sync.

[avallee, 2016/05/11 18:26:11]

Done.

[dcheng, 2016/05/11 18:46:58]

If this can never happen, why do we need the if (...)?

+}
+
 void WebViewImpl::setInitialFocus(bool reverse)
 {
     if (!m_page)
         return;
     Frame* frame = page()->focusController().focusedOrMainFrame();
     if (frame->isLocalFrame()) {
         if (Document* document = toLocalFrame(frame)->document())
             document->clearFocusedElement();
     }
     page()->focusController().setInitialFocus(reverse ? WebFocusTypeBackward : WebFocusTypeForward);
@@ skipping 1610 matching lines @@
 {
     // TODO(oshima): Investigate if this should return the ScreenInfo's scale factor rather than
     // page's scale factor, which can be 1 in use-zoom-for-dsf mode.
     if (!page())
         return 1;
 
     return page()->deviceScaleFactor();
 }
 
 } // namespace blink