Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1934603002: Suppress the autofill password manager after a credential was saved via the API. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Suppress the autofill password manager after a credential was saved via the API. Without this the user may see two save prompts one after another. BUG=607501 Review-Url: https://codereview.chromium.org/1929953002 Cr-Commit-Position: refs/heads/master@{#390384} (cherry picked from commit 86f6265c50793ff42c9853640610c20ba5eadbf6) Committed: https://chromium.googlesource.com/chromium/src/+/9663d49b8305d2b348cee20e8ec8bb007223601e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/credential_manager_browsertest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_manager_test_base.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_manager_test_base.cc View 4 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
vasilii
4 years, 7 months ago (2016-04-29 14:58:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9663d49b8305d2b348cee20e8ec8bb007223601e.

Powered by Google App Engine
This is Rietveld 408576698