Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1934573002:
Disable unit_tests_apk for ASAN temporarily (Closed)
DescriptionDisable unit_tests_apk for ASAN temporarily
Disabling the test suite on ASAN to fix the bot.
The unit_tests_apk was introduced as a followup to internal renaming here:
https://codereview.chromium.org/1924893004
Unfortunately, the internal ASAN recipe does not support the test suite named as
"unit_tests_apk". It tries to run:
out/Debug/bin/run_unit_tests_apk
And fails with "No such file or directory". What ran successfully before:
out/Debug/bin/run_unit_tests
Running the internal recipe has some pitfalls on the way (see
http://crbug.com/607879), so just making things greener for now.
BUG=607850
Committed: https://crrev.com/1d0e5bdab075461e4a66cad4a250d67ad1d37fa7
Cr-Commit-Position: refs/heads/master@{#390633}
Patch Set 1 #
Messages
Total messages: 14 (6 generated)
Description was changed from ========== Disable unit_tests_apk for ASAN temporarily Disabling the test suite on ASAN to fix the bot. The unit_tests_apk was introduced as a followup to internal renaming here: https://codereview.chromium.org/1924893004 Unfortunately, the internal ASAN recipe does not support the test suite named as "unit_tests_apk". Running the internal recipe has some pitfalls on the way (see http://crbug.com/607879). BUG=607850 ========== to ========== Disable unit_tests_apk for ASAN temporarily Disabling the test suite on ASAN to fix the bot. The unit_tests_apk was introduced as a followup to internal renaming here: https://codereview.chromium.org/1924893004 Unfortunately, the internal ASAN recipe does not support the test suite named as "unit_tests_apk". It tries to run: out/Debug/bin/run_unit_tests_apk And fails with "No such file or directory". What ran successfully before: out/Debug/bin/run_unit_tests Running the internal recipe has some pitfalls on the way (see http://crbug.com/607879), so just making things greener for now. BUG=607850 ==========
Description was changed from ========== Disable unit_tests_apk for ASAN temporarily Disabling the test suite on ASAN to fix the bot. The unit_tests_apk was introduced as a followup to internal renaming here: https://codereview.chromium.org/1924893004 Unfortunately, the internal ASAN recipe does not support the test suite named as "unit_tests_apk". It tries to run: out/Debug/bin/run_unit_tests_apk And fails with "No such file or directory". What ran successfully before: out/Debug/bin/run_unit_tests Running the internal recipe has some pitfalls on the way (see http://crbug.com/607879), so just making things greener for now. BUG=607850 ========== to ========== Disable unit_tests_apk for ASAN temporarily Disabling the test suite on ASAN to fix the bot. The unit_tests_apk was introduced as a followup to internal renaming here: https://codereview.chromium.org/1924893004 Unfortunately, the internal ASAN recipe does not support the test suite named as "unit_tests_apk". It tries to run: out/Debug/bin/run_unit_tests_apk And fails with "No such file or directory". What ran successfully before: out/Debug/bin/run_unit_tests Running the internal recipe has some pitfalls on the way (see http://crbug.com/607879), so just making things greener for now. BUG=607850 ==========
pasko@chromium.org changed reviewers: + jbudorick@chromium.org, lizeb@chromium.org, mikecase@chromium.org
lizeb: PTaL mikecase, jbudorick: FYI
On 2016/04/29 12:00:18, pasko wrote: > lizeb: PTaL > mikecase, jbudorick: FYI LGTM
The CQ bit was checked by pasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934573002/1
Message was sent while issue was closed.
Description was changed from ========== Disable unit_tests_apk for ASAN temporarily Disabling the test suite on ASAN to fix the bot. The unit_tests_apk was introduced as a followup to internal renaming here: https://codereview.chromium.org/1924893004 Unfortunately, the internal ASAN recipe does not support the test suite named as "unit_tests_apk". It tries to run: out/Debug/bin/run_unit_tests_apk And fails with "No such file or directory". What ran successfully before: out/Debug/bin/run_unit_tests Running the internal recipe has some pitfalls on the way (see http://crbug.com/607879), so just making things greener for now. BUG=607850 ========== to ========== Disable unit_tests_apk for ASAN temporarily Disabling the test suite on ASAN to fix the bot. The unit_tests_apk was introduced as a followup to internal renaming here: https://codereview.chromium.org/1924893004 Unfortunately, the internal ASAN recipe does not support the test suite named as "unit_tests_apk". It tries to run: out/Debug/bin/run_unit_tests_apk And fails with "No such file or directory". What ran successfully before: out/Debug/bin/run_unit_tests Running the internal recipe has some pitfalls on the way (see http://crbug.com/607879), so just making things greener for now. BUG=607850 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
We need a better way to deal with gtest suites on the bot that uses this.
Message was sent while issue was closed.
On 2016/04/29 14:50:51, jbudorick wrote: > We need a better way to deal with gtest suites on the bot that uses this. Can you throw a design sketch for this? I was not aware what the right behavior is supposed to be from all sides, so a minimal change looked most safe.
Message was sent while issue was closed.
On 2016/04/29 14:54:30, pasko wrote: > On 2016/04/29 14:50:51, jbudorick wrote: > > We need a better way to deal with gtest suites on the bot that uses this. > > Can you throw a design sketch for this? I was not aware what the right behavior > is supposed to be from all sides, so a minimal change looked most safe. Sure. I think a minimal change was the right way to go in the short term.
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1d0e5bdab075461e4a66cad4a250d67ad1d37fa7 Cr-Commit-Position: refs/heads/master@{#390633}
Message was sent while issue was closed.
Description was changed from ========== Disable unit_tests_apk for ASAN temporarily Disabling the test suite on ASAN to fix the bot. The unit_tests_apk was introduced as a followup to internal renaming here: https://codereview.chromium.org/1924893004 Unfortunately, the internal ASAN recipe does not support the test suite named as "unit_tests_apk". It tries to run: out/Debug/bin/run_unit_tests_apk And fails with "No such file or directory". What ran successfully before: out/Debug/bin/run_unit_tests Running the internal recipe has some pitfalls on the way (see http://crbug.com/607879), so just making things greener for now. BUG=607850 ========== to ========== Disable unit_tests_apk for ASAN temporarily Disabling the test suite on ASAN to fix the bot. The unit_tests_apk was introduced as a followup to internal renaming here: https://codereview.chromium.org/1924893004 Unfortunately, the internal ASAN recipe does not support the test suite named as "unit_tests_apk". It tries to run: out/Debug/bin/run_unit_tests_apk And fails with "No such file or directory". What ran successfully before: out/Debug/bin/run_unit_tests Running the internal recipe has some pitfalls on the way (see http://crbug.com/607879), so just making things greener for now. BUG=607850 Committed: https://crrev.com/1d0e5bdab075461e4a66cad4a250d67ad1d37fa7 Cr-Commit-Position: refs/heads/master@{#390633} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
