Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1924893004:
STABLE_TEST_SUITES: s/unit_tests/unit_tests_apk/ (Closed)
DescriptionSTABLE_TEST_SUITES: s/unit_tests/unit_tests_apk/
We used to add "_apk" to all targets from this list in the internal waterfall.
With a recent change by mikecase@ we no longer do that.
It works for most targets, but not for "unit_tests", which does not exist in GN.
This change would need to be reverted if we decide to switch back to GYP, but
it is unlikely to happen.
BUG=607455
Committed: https://crrev.com/9954a78c165554ffed0a978c5b84738f5fa83531
Cr-Commit-Position: refs/heads/master@{#390342}
Patch Set 1 #
Messages
Total messages: 16 (8 generated)
Description was changed from ========== STABLE_TEST_SUITES: s/unit_tests/unit_tests_apk/ We used to add "_apk" to all targets from this list in the internal waterfall. With a recent change by mikecase@ we no longer do that. It works for most targets, but not for "unit_tests", which does not exist in GN. This change would need to be reverted if we decide to switch back to GYP, but it is unlikely to happen. BUG=none ========== to ========== STABLE_TEST_SUITES: s/unit_tests/unit_tests_apk/ We used to add "_apk" to all targets from this list in the internal waterfall. With a recent change by mikecase@ we no longer do that. It works for most targets, but not for "unit_tests", which does not exist in GN. This change would need to be reverted if we decide to switch back to GYP, but it is unlikely to happen. BUG=none ==========
pasko@chromium.org changed reviewers: + lizeb@chromium.org, mikecase@chromium.org
lizeb: PTaL mikecase: FYI
On 2016/04/28 09:23:02, pasko wrote: > lizeb: PTaL > mikecase: FYI lgtm
Description was changed from ========== STABLE_TEST_SUITES: s/unit_tests/unit_tests_apk/ We used to add "_apk" to all targets from this list in the internal waterfall. With a recent change by mikecase@ we no longer do that. It works for most targets, but not for "unit_tests", which does not exist in GN. This change would need to be reverted if we decide to switch back to GYP, but it is unlikely to happen. BUG=none ========== to ========== STABLE_TEST_SUITES: s/unit_tests/unit_tests_apk/ We used to add "_apk" to all targets from this list in the internal waterfall. With a recent change by mikecase@ we no longer do that. It works for most targets, but not for "unit_tests", which does not exist in GN. This change would need to be reverted if we decide to switch back to GYP, but it is unlikely to happen. BUG=607455 ==========
The CQ bit was checked by pasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924893004/1
Message was sent while issue was closed.
Description was changed from ========== STABLE_TEST_SUITES: s/unit_tests/unit_tests_apk/ We used to add "_apk" to all targets from this list in the internal waterfall. With a recent change by mikecase@ we no longer do that. It works for most targets, but not for "unit_tests", which does not exist in GN. This change would need to be reverted if we decide to switch back to GYP, but it is unlikely to happen. BUG=607455 ========== to ========== STABLE_TEST_SUITES: s/unit_tests/unit_tests_apk/ We used to add "_apk" to all targets from this list in the internal waterfall. With a recent change by mikecase@ we no longer do that. It works for most targets, but not for "unit_tests", which does not exist in GN. This change would need to be reverted if we decide to switch back to GYP, but it is unlikely to happen. BUG=607455 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
jbudorick@chromium.org changed reviewers: + jbudorick@chromium.org
Message was sent while issue was closed.
FWIW, chrome/test:unit_tests does exist in GN: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/BUILD.... However, there's more than one "unit_tests" target in gn (e.g. https://code.google.com/p/chromium/codesearch#chromium/src/remoting/webapp/BU...), so no single target is available as simply "unit_tests" :(
Message was sent while issue was closed.
thanks!
Message was sent while issue was closed.
mikecase@google.com changed reviewers: + mikecase@google.com
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9954a78c165554ffed0a978c5b84738f5fa83531 Cr-Commit-Position: refs/heads/master@{#390342}
Message was sent while issue was closed.
Description was changed from ========== STABLE_TEST_SUITES: s/unit_tests/unit_tests_apk/ We used to add "_apk" to all targets from this list in the internal waterfall. With a recent change by mikecase@ we no longer do that. It works for most targets, but not for "unit_tests", which does not exist in GN. This change would need to be reverted if we decide to switch back to GYP, but it is unlikely to happen. BUG=607455 ========== to ========== STABLE_TEST_SUITES: s/unit_tests/unit_tests_apk/ We used to add "_apk" to all targets from this list in the internal waterfall. With a recent change by mikecase@ we no longer do that. It works for most targets, but not for "unit_tests", which does not exist in GN. This change would need to be reverted if we decide to switch back to GYP, but it is unlikely to happen. BUG=607455 Committed: https://crrev.com/9954a78c165554ffed0a978c5b84738f5fa83531 Cr-Commit-Position: refs/heads/master@{#390342} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
