Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1934553002: Avoid use of NonConstantValue in SSA (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid use of NonConstantValue in SSA BUG= Committed: https://github.com/dart-lang/sdk/commit/8e70d3bd83f9b41c326f72393726149b4e254a7b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/compiler/lib/src/constants/values.dart View 1 chunk +1 line, -1 line 2 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
TBR
4 years, 7 months ago (2016-04-29 11:33:19 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as 8e70d3bd83f9b41c326f72393726149b4e254a7b (presubmit successful).
4 years, 7 months ago (2016-04-29 11:33:43 UTC) #4
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1934553002/diff/1/pkg/compiler/lib/src/constants/values.dart File pkg/compiler/lib/src/constants/values.dart (right): https://codereview.chromium.org/1934553002/diff/1/pkg/compiler/lib/src/constants/values.dart#newcode162 pkg/compiler/lib/src/constants/values.dart:162: const factory NullConstantValue() = NullConstantValue._internal; I didn't know ...
4 years, 7 months ago (2016-04-29 20:26:40 UTC) #5
Johnni Winther
4 years, 7 months ago (2016-04-30 09:06:03 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1934553002/diff/1/pkg/compiler/lib/src/consta...
File pkg/compiler/lib/src/constants/values.dart (right):

https://codereview.chromium.org/1934553002/diff/1/pkg/compiler/lib/src/consta...
pkg/compiler/lib/src/constants/values.dart:162: const factory
NullConstantValue() = NullConstantValue._internal;
On 2016/04/29 20:26:40, Siggi Cherem (dart-lang) wrote:
> I didn't know we were allowed to declare a factory constructor as const

When they are redirecting we can (I changed that too).

Powered by Google App Engine
This is Rietveld 408576698