pkg/compiler/lib/src/constants/values.dart - Issue 1934553002: Avoid use of NonConstantValue in SSA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/constants/values.dart

Issue 1934553002: Avoid use of NonConstantValue in SSA (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/constants/values.dart

diff --git a/pkg/compiler/lib/src/constants/values.dart b/pkg/compiler/lib/src/constants/values.dart

index fd0f5dd763e018decd049fc672bb60bd2fb3dce8..37f5646d7e3600f22f575df233d3153b2273f62e 100644

--- a/pkg/compiler/lib/src/constants/values.dart

+++ b/pkg/compiler/lib/src/constants/values.dart

@@ -159,7 +159,7 @@ class NullConstantValue extends PrimitiveConstantValue {

/** The value a Dart null is compiled to in JavaScript. */

static const String JsNull = "null";

- factory NullConstantValue() => const NullConstantValue._internal();

+ const factory NullConstantValue() = NullConstantValue._internal;

Siggi Cherem (dart-lang) 2016/04/29 20:26:40 I didn't know we were allowed to declare a factory

Johnni Winther 2016/04/30 09:06:02 When they are redirecting we can (I changed that t

const NullConstantValue._internal();

« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/nodes.dart » ('j') | no next file with comments »