Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1934193003: media: Set MediaClientAndroid in the GPU process. (Closed)

Created:
4 years, 7 months ago by xhwang
Modified:
4 years, 7 months ago
Reviewers:
slan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

media: Set MediaClientAndroid in the GPU process. Now on Android we use MediaDrmBridge in the GPU process. We should set MediaClientAndroid the same as we do in the Browser process. Summary of changes: - Add ContentClient::GetMediaClientAndroid() API. - SetMediaClientAndroid() in GPU process. Today in the browser, we call media::SetMediaClientAndroid() directly from content embedders (e.g. ChromeBrowserMainPartsAndroid), which seems hacky. We should use ContentClient::GetMediaClientAndroid() in the browser process as well so that content will talk to the embedder, and then talk to media. I'll work on it after this CL. TBR=slan@chromium.org BUG=605330 TEST=Encrypted Widevine contents plays in the GPU process on Android K. Review-Url: https://codereview.chromium.org/1907263003 Cr-Commit-Position: refs/heads/master@{#390517} (cherry picked from commit f258baab74abe43f7f77bdae8b74c61c07f95f51) Committed: https://chromium.googlesource.com/chromium/src/+/9f877f4a9a89650c651f63d74f3952914306e14f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -160 lines) Patch
M android_webview/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/browser/aw_media_client_android.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/android/chrome_media_client_android.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/android/chrome_media_client_android.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_content_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 2 chunks +10 lines, -0 lines 0 comments Download
A + chrome/common/chrome_media_client_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/common/chrome_media_client_android.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chromecast/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/media/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/media/cast_media_client_android.h View 1 chunk +1 line, -1 line 0 comments Download
M components/cdm.gypi View 2 chunks +8 lines, -2 lines 0 comments Download
M components/cdm/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/cdm/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/cdm/browser/widevine_drm_delegate_android.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/cdm/browser/widevine_drm_delegate_android.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M components/cdm/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/cdm/common/widevine_drm_delegate_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cdm/common/widevine_drm_delegate_android.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M content/gpu/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_process_control_impl.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M content/public/common/content_client.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/public/common/content_client.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
xhwang
Committed patchset #1 (id:1) manually as 9f877f4a9a89650c651f63d74f3952914306e14f.
4 years, 7 months ago (2016-05-02 18:23:21 UTC) #2
slan
4 years, 7 months ago (2016-05-05 18:52:07 UTC) #3
Message was sent while issue was closed.
cast lgtm

Powered by Google App Engine
This is Rietveld 408576698