Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1934193002: Add system.gyp:glib as dependency to os_crypt.gypi (Closed)

Created:
4 years, 7 months ago by joone
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add system.gyp:glib as dependency to os_crypt.gypi When building chrome with GYP_DEFINES=use_ozone=1 ozone_platform_wayland=1 use_wayland_egl=1 use_gtk=0 use_egl=1, the following build error occurred. In file included from ../../components/os_crypt/libsecret_util_posix.cc:5: In file included from ../../components/os_crypt/libsecret_util_posix.h:8: ../../third_party/libsecret/libsecret/secret.h:18:10: fatal error: 'glib.h' file not found ^ 1 error generated. system.gyp:glib has to be added to os_crypt.gypi to fix the error. We also need to update BUILD.gn accordingly. TEST=build chrome with GYP_DEFINES=use_ozone=1 ozone_platform_wayland=1 use_wayland_egl=1 use_gtk=0 use_egl=1 BUG=none Committed: https://crrev.com/443264cd31699ea0a21676b7310055b989c262fd Cr-Commit-Position: refs/heads/master@{#391229}

Patch Set 1 #

Patch Set 2 : Update the gn file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/os_crypt.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M components/os_crypt/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
joone
Hi, please take a look at this CL.
4 years, 7 months ago (2016-05-02 07:19:10 UTC) #2
jochen (gone - plz use gerrit)
On 2016/05/02 at 07:19:10, joone.hur wrote: > Hi, please take a look at this CL. ...
4 years, 7 months ago (2016-05-02 16:14:00 UTC) #3
joone
On 2016/05/02 16:14:00, jochen wrote: > On 2016/05/02 at 07:19:10, joone.hur wrote: > > Hi, ...
4 years, 7 months ago (2016-05-02 21:52:16 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-03 11:01:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934193002/20001
4 years, 7 months ago (2016-05-03 14:33:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 14:40:00 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 14:41:57 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/443264cd31699ea0a21676b7310055b989c262fd
Cr-Commit-Position: refs/heads/master@{#391229}

Powered by Google App Engine
This is Rietveld 408576698