Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1934183002: Have htmlcollection-reachable.html force the one GC needed. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have htmlcollection-reachable.html force the one GC needed. Calling window.gc() slows down test running times, and is preferably avoided unless needed to verify behavior across a GC. For htmlcollection-reachable.html, we only need the one GC to determine liveness of custom properties for various platform objects across a garbage collection. R= BUG=593888 Committed: https://crrev.com/fcb30081090c3906aa2c50d5b7b9f57b7987b24e Cr-Commit-Position: refs/heads/master@{#390872}

Patch Set 1 #

Patch Set 2 : sync expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/htmlcollection-reachable.html View 1 1 chunk +8 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/htmlcollection-reachable-expected.txt View 1 1 chunk +17 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-01 16:12:00 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-01 17:35:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934183002/20001
4 years, 7 months ago (2016-05-01 21:49:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-01 21:52:56 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 21:54:27 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fcb30081090c3906aa2c50d5b7b9f57b7987b24e
Cr-Commit-Position: refs/heads/master@{#390872}

Powered by Google App Engine
This is Rietveld 408576698