Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 19341003: Remove CanUseFastAttribute subroutine from the generator (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 5 months ago
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, lgombos
Visibility:
Public.

Description

Remove CanUseFastAttribute subroutine from the generator Remove CanUseFastAttribute subroutine from the generator as it makes the code more complex but has no impact on the generated code. Only SVG animated types cannot use getFastAttribute, however, no attribute of SVG animated type is specified to [Reflect]. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154286

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M Source/bindings/scripts/deprecated_code_generator_v8.pm View 3 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
do-not-use
7 years, 5 months ago (2013-07-16 07:25:54 UTC) #1
haraken
LGTM
7 years, 5 months ago (2013-07-16 07:26:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19341003/1
7 years, 5 months ago (2013-07-16 07:29:12 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16965
7 years, 5 months ago (2013-07-16 12:04:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19341003/1
7 years, 5 months ago (2013-07-16 12:16:58 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16990
7 years, 5 months ago (2013-07-16 13:13:26 UTC) #6
do-not-use
Committed as 154286
7 years, 5 months ago (2013-07-16 13:57:42 UTC) #7
abarth-chromium
Is there a runtime or compile check to catch us if we add [Reflect] to ...
7 years, 5 months ago (2013-07-16 22:13:56 UTC) #8
do-not-use
7 years, 5 months ago (2013-07-17 06:40:06 UTC) #9
Message was sent while issue was closed.
On 2013/07/16 22:13:56, abarth wrote:
> Is there a runtime or compile check to catch us if we add [Reflect] to one of
> these attributes in the future?

No, there is not. You make a good point. I'll add a check for it to be safe.

Powered by Google App Engine
This is Rietveld 408576698