Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 19341003: Remove CanUseFastAttribute subroutine from the generator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/deprecated_code_generator_v8.pm
diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm
index ee5a0e85497c03c894056cb4c8d265b5d0c6e7f4..c2aaa5667577f38d55310e70b51a383eeb9860ec 100644
--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm
+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm
@@ -5856,12 +5856,6 @@ sub ContentAttributeName
return "WebCore::${namespace}::${contentAttributeName}Attr";
}
-sub CanUseFastAttribute
-{
- my $attribute = shift;
- return !IsSVGAnimatedType($attribute->type);
-}
-
sub GetterExpression
{
my ($interfaceName, $attribute) = @_;
@@ -5876,11 +5870,7 @@ sub GetterExpression
if ($attribute->extendedAttributes->{"URL"}) {
$functionName = "getURLAttribute";
} elsif ($attribute->type eq "boolean") {
- if (CanUseFastAttribute($attribute)) {
- $functionName = "fastHasAttribute";
- } else {
- $functionName = "hasAttribute";
- }
+ $functionName = "fastHasAttribute";
} elsif ($attribute->type eq "long") {
$functionName = "getIntegralAttribute";
} elsif ($attribute->type eq "unsigned long") {
@@ -5895,10 +5885,8 @@ sub GetterExpression
} elsif ($contentAttributeName eq "WebCore::HTMLNames::classAttr") {
$functionName = "getClassAttribute";
$contentAttributeName = "";
- } elsif (CanUseFastAttribute($attribute)) {
- $functionName = "fastGetAttribute";
} else {
- $functionName = "getAttribute";
+ $functionName = "fastGetAttribute";
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698