quic: check for stream_factory_ to be non-null before all accesses.

quic: check for stream_factory_ to be non-null before all accesses.

One of the missing checks was the reason for net_unittests to fail
under ubsan_vptr mode.

BUG=607996
Committed: https://crrev.com/59fcd05345fcad7387085a745a6a254e0c70d6a3
Cr-Commit-Position: refs/heads/master@{#390859}

[krasin, 2016-04-29 23:44:28]

krasin@google.com changed reviewers:
+ dpranke@google.com, mef@chromium.org

[krasin, 2016-04-29 23:44:29]

Misha, please, LGTM the quic changes.
Dirk, please, approve adding net_unittests back to 'UBSanVptr Linux' buildbot.

[krasin, 2016-04-29 23:44:37]

The CQ bit was checked by krasin@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 23:44:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1934043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1934043002/1

[mef, 2016-04-29 23:54:42]

Description was changed from

==========
quic: check for stream_factory_ to be non-null before all accesses.

One of the missing checks was the reason for net_unittests to fail
under ubsan_vptr mode.

BUG=607996
==========

to

==========
quic: check for stream_factory_ to be non-null before all accesses.

One of the missing checks was the reason for net_unittests to fail
under ubsan_vptr mode.

BUG=607996
==========

[mef, 2016-04-29 23:54:42]

mef@chromium.org changed reviewers:
+ rtenneti@chromium.org
- mef@chromium.org

[mef, 2016-04-29 23:55:17]

mef@chromium.org changed reviewers:
+ mef@chromium.org

[mef, 2016-04-29 23:55:17]

Raman, could you take a look?

[Dirk Pranke, 2016-04-29 23:57:13]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-04-29 23:57:13]

lgtm

[commit-bot: I haz the power, 2016-04-30 00:45:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-30 00:45:55]

Dry run: This issue passed the CQ dry run.

[ramant (doing other things), 2016-04-30 18:00:53]

lgtm

[krasin, 2016-04-30 18:05:56]

Thanks!

[krasin, 2016-04-30 18:06:02]

The CQ bit was checked by krasin@google.com

[commit-bot: I haz the power, 2016-04-30 18:06:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1934043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1934043002/1

[commit-bot: I haz the power, 2016-04-30 18:58:04]

Description was changed from

==========
quic: check for stream_factory_ to be non-null before all accesses.

One of the missing checks was the reason for net_unittests to fail
under ubsan_vptr mode.

BUG=607996
==========

to

==========
quic: check for stream_factory_ to be non-null before all accesses.

One of the missing checks was the reason for net_unittests to fail
under ubsan_vptr mode.

BUG=607996
==========

[commit-bot: I haz the power, 2016-04-30 18:58:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-30 18:59:14]

Description was changed from

==========
quic: check for stream_factory_ to be non-null before all accesses.

One of the missing checks was the reason for net_unittests to fail
under ubsan_vptr mode.

BUG=607996
==========

to

==========
quic: check for stream_factory_ to be non-null before all accesses.

One of the missing checks was the reason for net_unittests to fail
under ubsan_vptr mode.

BUG=607996

Committed: https://crrev.com/59fcd05345fcad7387085a745a6a254e0c70d6a3
Cr-Commit-Position: refs/heads/master@{#390859}
==========

[commit-bot: I haz the power, 2016-04-30 18:59:15]

Patchset 1 (id:??) landed as
https://crrev.com/59fcd05345fcad7387085a745a6a254e0c70d6a3
Cr-Commit-Position: refs/heads/master@{#390859}

[Nico, 2016-05-01 01:24:14]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-05-01 01:24:15]

https://codereview.chromium.org/1934043002/diff/1/testing/buildbot/chromium.f...
File testing/buildbot/chromium.fyi.json (right):

https://codereview.chromium.org/1934043002/diff/1/testing/buildbot/chromium.f...
testing/buildbot/chromium.fyi.json:2278: },
do you want to add this to ClangToTLinuxUBSanVptr tester too? probably good if
the tests on the two ubsan bots match (?)