Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: net/quic/quic_chromium_client_session.cc

Issue 1934043002: quic: check for stream_factory_ to be non-null before all accesses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/buildbot/chromium.fyi.json » ('j') | testing/buildbot/chromium.fyi.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_chromium_client_session.cc
diff --git a/net/quic/quic_chromium_client_session.cc b/net/quic/quic_chromium_client_session.cc
index 44dc0f0e18dfe5b4b3ce7985b3ef4fba546892d2..c4b99f62dda0d5888473a3587f0d607619490a92 100644
--- a/net/quic/quic_chromium_client_session.cc
+++ b/net/quic/quic_chromium_client_session.cc
@@ -705,7 +705,7 @@ void QuicChromiumClientSession::OnClosedStream() {
request->OnRequestCompleteSuccess(CreateOutgoingReliableStreamImpl());
}
- if (GetNumOpenOutgoingStreams() == 0) {
+ if (GetNumOpenOutgoingStreams() == 0 && stream_factory_) {
stream_factory_->OnIdleSession(this);
}
}
@@ -909,7 +909,9 @@ void QuicChromiumClientSession::OnSuccessfulVersionNegotiation(
}
void QuicChromiumClientSession::OnPathDegrading() {
- stream_factory_->MaybeMigrateSessionEarly(this);
+ if (stream_factory_) {
+ stream_factory_->MaybeMigrateSessionEarly(this);
+ }
}
void QuicChromiumClientSession::OnProofValid(
« no previous file with comments | « no previous file | testing/buildbot/chromium.fyi.json » ('j') | testing/buildbot/chromium.fyi.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698