Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1933833002: Fix bogus warning message for touch drag gesture used cross origin. (Closed)

Created:
4 years, 7 months ago by dtapuska
Modified:
4 years, 7 months ago
Reviewers:
bokan, Rick Byers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bogus warning message for touch drag gesture used cross origin. The chromestatus URI prefix was added twice. willBeRemoved does a sprintf with the URI on the front. BUG=582140 Committed: https://crrev.com/97a365a7a2fef83461694833288a0f8d18769404 Cr-Commit-Position: refs/heads/master@{#390718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
dtapuska
Good eyes bokan!
4 years, 7 months ago (2016-04-29 17:49:02 UTC) #3
bokan
lgtm
4 years, 7 months ago (2016-04-29 17:49:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933833002/1
4 years, 7 months ago (2016-04-29 17:50:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 19:30:02 UTC) #8
Rick Byers
Oh whoops, thanks!
4 years, 7 months ago (2016-04-30 04:06:11 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:27:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97a365a7a2fef83461694833288a0f8d18769404
Cr-Commit-Position: refs/heads/master@{#390718}

Powered by Google App Engine
This is Rietveld 408576698