Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1933703002: TaskScheduler: Fix comments in SchedulerThreadPool. (Closed)

Created:
4 years, 7 months ago by fdoray
Modified:
4 years, 7 months ago
Reviewers:
gab
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TaskScheduler: Fix comments in SchedulerThreadPool. BUG=553459 Committed: https://crrev.com/8ba367a2c938f22a6ec136f6ca49ad1911d67d81 Cr-Commit-Position: refs/heads/master@{#390663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M base/task_scheduler/scheduler_thread_pool.h View 1 chunk +17 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fdoray
This CL fixes comments as requested here https://codereview.chromium.org/1906083002/diff/140001/base/task_scheduler/scheduler_thread_pool.h#newcode36 Can you review it? Thanks!
4 years, 7 months ago (2016-04-29 14:18:28 UTC) #2
gab
lgtm
4 years, 7 months ago (2016-04-29 14:37:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933703002/1
4 years, 7 months ago (2016-04-29 14:52:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 16:08:18 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:26:12 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8ba367a2c938f22a6ec136f6ca49ad1911d67d81
Cr-Commit-Position: refs/heads/master@{#390663}

Powered by Google App Engine
This is Rietveld 408576698