Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: base/task_scheduler/scheduler_thread_pool.h

Issue 1933703002: TaskScheduler: Fix comments in SchedulerThreadPool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_H_ 5 #ifndef BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_H_
6 #define BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_H_ 6 #define BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/base_export.h" 10 #include "base/base_export.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "base/task_runner.h" 12 #include "base/task_runner.h"
13 #include "base/task_scheduler/sequence.h" 13 #include "base/task_scheduler/sequence.h"
14 #include "base/task_scheduler/task.h" 14 #include "base/task_scheduler/task.h"
15 #include "base/task_scheduler/task_traits.h" 15 #include "base/task_scheduler/task_traits.h"
16 16
17 namespace base { 17 namespace base {
18 namespace internal { 18 namespace internal {
19 19
20 class SchedulerWorkerThread; 20 class SchedulerWorkerThread;
21 class SequenceSortKey; 21 class SequenceSortKey;
22 22
23 // Interface for a thread pool. 23 // Interface for a thread pool.
24 class BASE_EXPORT SchedulerThreadPool { 24 class BASE_EXPORT SchedulerThreadPool {
25 public: 25 public:
26 virtual ~SchedulerThreadPool() = default; 26 virtual ~SchedulerThreadPool() = default;
27 27
28 // Returns a TaskRunner whose PostTask invocations will result in scheduling 28 // Returns a TaskRunner whose PostTask invocations will result in scheduling
29 // Tasks with |traits| and |execution_mode| in this thread pool. 29 // Tasks with |traits| and |execution_mode| in this SchedulerThreadPool.
30 virtual scoped_refptr<TaskRunner> CreateTaskRunnerWithTraits( 30 virtual scoped_refptr<TaskRunner> CreateTaskRunnerWithTraits(
31 const TaskTraits& traits, 31 const TaskTraits& traits,
32 ExecutionMode execution_mode) = 0; 32 ExecutionMode execution_mode) = 0;
33 33
34 // Inserts |sequence| into this thread pool's shared priority queue with 34 // Inserts |sequence| with |sequence_sort_key| into a queue of Sequences that
35 // |sequence_sort_key|. Must only be called from a worker thread to put 35 // can be processed by any worker thread owned by this SchedulerThreadPool.
36 // |sequence| back into a PriorityQueue after running a Task from it. The 36 // Must only be used to put |sequence| back into a queue after running a Task
37 // worker thread doesn't have to belong to this thread pool. 37 // from it. The thread that calls this doesn't have to belong to this
38 // SchedulerThreadPool.
38 virtual void ReEnqueueSequence(scoped_refptr<Sequence> sequence, 39 virtual void ReEnqueueSequence(scoped_refptr<Sequence> sequence,
39 const SequenceSortKey& sequence_sort_key) = 0; 40 const SequenceSortKey& sequence_sort_key) = 0;
40 41
41 // Posts |task| to be executed as part of |sequence|. If |worker_thread| is 42 // Posts |task| to be executed by this SchedulerThreadPool as part of
42 // non-null, |task| will be scheduled to run on it specifically (note: 43 // |sequence|. If |worker_thread| is non-null, |task| will be scheduled to run
43 // |worker_thread| must be owned by this SchedulerThreadPool); otherwise, 44 // on it specifically (note: |worker_thread| must be owned by this
44 // |task| will be added to the pending shared work. Returns true if |task| is 45 // SchedulerThreadPool); otherwise, |task| will be added to the pending shared
45 // posted. 46 // work. |task| won't be executed before its delayed run time, if any. Returns
47 // true if |task| is posted.
46 virtual bool PostTaskWithSequence(std::unique_ptr<Task> task, 48 virtual bool PostTaskWithSequence(std::unique_ptr<Task> task,
47 scoped_refptr<Sequence> sequence, 49 scoped_refptr<Sequence> sequence,
48 SchedulerWorkerThread* worker_thread) = 0; 50 SchedulerWorkerThread* worker_thread) = 0;
49 51
50 // Posts |task| to be executed by this thread pool as part of |sequence|. If 52 // Posts |task| to be executed by this SchedulerThreadPool as part of
51 // |worker_thread| is non-null, |task| will be scheduled to run on it 53 // |sequence|. If |worker_thread| is non-null, |task| will be scheduled to run
52 // specifically (note: |worker_thread| must be owned by this 54 // on it specifically (note: |worker_thread| must be owned by this
53 // SchedulerThreadPool); otherwise, |task| will be added to the pending shared 55 // SchedulerThreadPool); otherwise, |task| will be added to the pending shared
54 // work. The scheduler's TaskTracker must have allowed |task| to be posted 56 // work. This must only be called after |task| has gone through
55 // before this is called. This must only be called after |task|'s delayed run 57 // PostTaskWithSequence() and after |task|'s delayed run time.
56 // time.
57 virtual void PostTaskWithSequenceNow( 58 virtual void PostTaskWithSequenceNow(
58 std::unique_ptr<Task> task, 59 std::unique_ptr<Task> task,
59 scoped_refptr<Sequence> sequence, 60 scoped_refptr<Sequence> sequence,
60 SchedulerWorkerThread* worker_thread) = 0; 61 SchedulerWorkerThread* worker_thread) = 0;
61 }; 62 };
62 63
63 } // namespace internal 64 } // namespace internal
64 } // namespace base 65 } // namespace base
65 66
66 #endif // BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_H_ 67 #endif // BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698