Mojom frontend: Start populating |resolved_concrete_value| field in mojom_types.mojom

Mojom frontend: Start populating |resolved_concrete_value| field in mojom_types.mojom

In struct DeclaredConstant in mojom_types.mojom there is a field |resolved_concrete_value| that has been commented out and thus (obviously) not populated. The corresponding value has always been computed in the frontend Go code but we were not populating it in the intermediate representation because we were not aware of any reason to do so.

But now Vardhan will be able to use this in the new C generator. (Also I think some of the existing generators such as Dart will be able to stop computing this value themselves).

- I also added some additional tests of the existing computation of this value.

- I also fixed the name of an unrelated enum value in user_defined_types.go that I happened to notice was misnamed.

R=azani@chromium.org, vardhan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/f38d5d7e77ceb6b015d87d2d42bc4606090803df

[rudominer, 2016-04-29 00:59:04]

Description was changed from

==========
Mojom frontend: Start populating |resolved_concrete_value| field in
mojom_types.mojom

fixes #694
==========

to

==========
Mojom frontend: Start populating |resolved_concrete_value| field in
mojom_types.mojom

In struct DeclaredConstant in mojom_types.mojom there is a field
|resolved_concrete_value| that has been commented out and thus (obviously) not
populated. The corresponding value has always been computed in the frontend Go
code but we were not populating it in the intermediate representation because we
were not aware of any reason to do so.

But now Vardhan will be able to use this in the new C generator. (Also I think
some of the existing generators such as Dart will be able to stop computing this
value themselves).

I also added some additional tests of the existing computation of this value.
==========

[rudominer, 2016-04-29 01:07:56]

Description was changed from

==========
Mojom frontend: Start populating |resolved_concrete_value| field in
mojom_types.mojom

In struct DeclaredConstant in mojom_types.mojom there is a field
|resolved_concrete_value| that has been commented out and thus (obviously) not
populated. The corresponding value has always been computed in the frontend Go
code but we were not populating it in the intermediate representation because we
were not aware of any reason to do so.

But now Vardhan will be able to use this in the new C generator. (Also I think
some of the existing generators such as Dart will be able to stop computing this
value themselves).

I also added some additional tests of the existing computation of this value.
==========

to

==========
Mojom frontend: Start populating |resolved_concrete_value| field in
mojom_types.mojom

In struct DeclaredConstant in mojom_types.mojom there is a field
|resolved_concrete_value| that has been commented out and thus (obviously) not
populated. The corresponding value has always been computed in the frontend Go
code but we were not populating it in the intermediate representation because we
were not aware of any reason to do so.

But now Vardhan will be able to use this in the new C generator. (Also I think
some of the existing generators such as Dart will be able to stop computing this
value themselves).

- I also added some additional tests of the existing computation of this value.

- I also fixed the name of an unrelated enum value in user_defined_types.go that
I happened to notice was misnamed.
==========

[rudominer, 2016-04-29 01:11:12]

rudominer@chromium.org changed reviewers:
+ azani@chromium.org, vardhan@google.com

[rudominer, 2016-04-29 01:11:13]

Vardhan, Alex, ptal.

[vardhan, 2016-04-29 02:30:35]

lgtm w/ a nit.

thanks!

https://codereview.chromium.org/1933563002/diff/1/mojo/public/interfaces/bind...
File mojo/public/interfaces/bindings/mojom_types.mojom (right):

https://codereview.chromium.org/1933563002/diff/1/mojo/public/interfaces/bind...
mojo/public/interfaces/bindings/mojom_types.mojom:393: // concrete value is is
conceptually equal to |value| and this will
nit: is is

[rudominer, 2016-04-29 18:08:30]

Thanks Vardhan. Alex would you like me to wait for you to look also?

https://codereview.chromium.org/1933563002/diff/1/mojo/public/interfaces/bind...
File mojo/public/interfaces/bindings/mojom_types.mojom (right):

https://codereview.chromium.org/1933563002/diff/1/mojo/public/interfaces/bind...
mojo/public/interfaces/bindings/mojom_types.mojom:393: // concrete value is is
conceptually equal to |value| and this will
On 2016/04/29 02:30:34, vardhan wrote:
> nit: is is

Done.

[azani, 2016-04-29 18:34:45]

lgtm

[rudominer, 2016-04-29 18:51:36]

Description was changed from

==========
Mojom frontend: Start populating |resolved_concrete_value| field in
mojom_types.mojom

In struct DeclaredConstant in mojom_types.mojom there is a field
|resolved_concrete_value| that has been commented out and thus (obviously) not
populated. The corresponding value has always been computed in the frontend Go
code but we were not populating it in the intermediate representation because we
were not aware of any reason to do so.

But now Vardhan will be able to use this in the new C generator. (Also I think
some of the existing generators such as Dart will be able to stop computing this
value themselves).

- I also added some additional tests of the existing computation of this value.

- I also fixed the name of an unrelated enum value in user_defined_types.go that
I happened to notice was misnamed.
==========

to

==========
Mojom frontend: Start populating |resolved_concrete_value| field in
mojom_types.mojom

In struct DeclaredConstant in mojom_types.mojom there is a field
|resolved_concrete_value| that has been commented out and thus (obviously) not
populated. The corresponding value has always been computed in the frontend Go
code but we were not populating it in the intermediate representation because we
were not aware of any reason to do so.

But now Vardhan will be able to use this in the new C generator. (Also I think
some of the existing generators such as Dart will be able to stop computing this
value themselves).

- I also added some additional tests of the existing computation of this value.

- I also fixed the name of an unrelated enum value in user_defined_types.go that
I happened to notice was misnamed.

R=azani@chromium.org, vardhan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/f38d5d7e77ceb6b015d87d2d42b...
==========

[rudominer, 2016-04-29 18:51:38]

Committed patchset #2 (id:20001) manually as
f38d5d7e77ceb6b015d87d2d42bc4606090803df (presubmit successful).