Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: mojom/mojom_tool/mojom/user_defined_types.go

Issue 1933563002: Mojom frontend: Start populating |resolved_concrete_value| field in mojom_types.mojom (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Grammar fix. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojom/mojom_tool/mojom/user_defined_types.go
diff --git a/mojom/mojom_tool/mojom/user_defined_types.go b/mojom/mojom_tool/mojom/user_defined_types.go
index 0234bfeb76366d3fa472e433dbf79ddfa34ecf3f..fbd8d6e34ba7ea7f23b46b6a61980fc1fba67471 100644
--- a/mojom/mojom_tool/mojom/user_defined_types.go
+++ b/mojom/mojom_tool/mojom/user_defined_types.go
@@ -991,7 +991,7 @@ func (e *MojomEnum) InitAsScope(parentScope *Scope) *Scope {
// Adds an EnumValue to this enum
func (e *MojomEnum) AddEnumValue(declData DeclarationData, valueRef ValueRef) DuplicateNameError {
enumValue := new(EnumValue)
- enumValue.Init(declData, UserDefinedValueKindEnum, enumValue, valueRef)
+ enumValue.Init(declData, UserDefinedValueKindEnumValue, enumValue, valueRef)
e.Values = append(e.Values, enumValue)
e.DeclaredObjects = append(e.DeclaredObjects, enumValue)
enumValue.enumType = e
@@ -1057,14 +1057,14 @@ func (ev *EnumValue) String() string {
type UserDefinedValueKind int
const (
- UserDefinedValueKindEnum UserDefinedValueKind = iota
+ UserDefinedValueKindEnumValue UserDefinedValueKind = iota
UserDefinedValueKindDeclaredConst
UserDefinedValueKindBuiltInConst
)
func (k UserDefinedValueKind) String() string {
switch k {
- case UserDefinedValueKindEnum:
+ case UserDefinedValueKindEnumValue:
return "enum value"
case UserDefinedValueKindDeclaredConst:
return "const"
@@ -1112,7 +1112,7 @@ func (v *UserDefinedValueBase) RegisterInScope(scope *Scope) DuplicateNameError
return err
}
- if v.thisValue.Kind() == UserDefinedValueKindEnum {
+ if v.thisValue.Kind() == UserDefinedValueKindEnumValue {
if scope.kind != ScopeEnum {
panic("An enum value may only be registered within the scope of an enum.")
}
« no previous file with comments | « mojom/mojom_tool/integration_tests/resolution_test.go ('k') | mojom/mojom_tool/mojom/user_defined_types_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698