Production quality fast image up/downsampler

include/core/SkBitmap.h

Index: include/core/SkBitmap.h
diff --git a/include/core/SkBitmap.h b/include/core/SkBitmap.h
index d5277c6c80c6b75b9b0f45785db07c17fe7f5d1a..67e98b69cb9a9008e51c6c51541fc126de66ae8a 100644
--- a/include/core/SkBitmap.h
+++ b/include/core/SkBitmap.h
@@ -22,6 +22,8 @@ class SkPaint;
 class SkPixelRef;
 class SkRegion;
 class SkString;
+class SkBitmapFilter;
+class SkConvolutionProcs;
 
 class GrTexture;
 
@@ -702,18 +704,8 @@ private:
     int extractMipLevel(SkBitmap* dst, SkFixed sx, SkFixed sy);
     bool hasMipMap() const;
     void freeMipMap();
-
-    /** Make a scaled copy of this bitmap into the provided destination.
-      * The caller is responsible for having set the width and height of the
-      * provided destination bitmap, and also having allocated its pixel
-      * memory.
-      *
-      * This function is temporary and for testing purposes only; it will
-      * likely move once it has been properly plumbed into the bitmap
-      * shader infrastructure.
-      */
-
-    void scale(SkBitmap *dst) const;
+    
+    static void scale( const SkBitmap *src, SkBitmap *dst );

[reed1, 2013/07/18 13:42:12]

Static Methods Are Capitalized

Should this guy either take a quality level, or have its name indicated what
level its going to do?

[humper, 2013/07/18 17:11:04]

Sorry, this function should have been deleted from the header.  It no longer
exists.  Nice catch.

 
     friend struct SkBitmapProcState;
 };