Issue 193323003: Paper over a recent null-ptr crash regression in SVGImage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193323003: Paper over a recent null-ptr crash regression in SVGImage (Closed)

Created:
6 years, 9 months ago by eseidel

Modified:
6 years, 9 months ago

Reviewers:
haraken

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Paper over a recent null-ptr crash regression in SVGImage I don't like this patch, but this unblock's Karen's ability to roll, while we decide if we're going to roll out the recent SVGImage page-destruction deferal code or if we can add a test for this ASSERT and clarify the lifetime so that others who might expect to still have a Page object don't have similar confusion. BUG=350907 TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168861

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	Source/core/svg/graphics/SVGImageChromeClient.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

Committed patchset #1 manually as r168861 (presubmit successful).

6 years, 9 months ago (2014-03-10 22:06:08 UTC) #1

eseidel

6 years, 9 months ago (2014-03-11 04:48:36 UTC) #3

Message was sent while issue was closed.

It looks like canvas/philip/tests/2d.drawImage.floatsource reproduces.

Expand Messages | Collapse Messages