Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Unified Diff: Source/core/svg/graphics/SVGImageChromeClient.cpp

Issue 193323003: Paper over a recent null-ptr crash regression in SVGImage (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/graphics/SVGImageChromeClient.cpp
diff --git a/Source/core/svg/graphics/SVGImageChromeClient.cpp b/Source/core/svg/graphics/SVGImageChromeClient.cpp
index 54045c01b50d843410fdb627d97b577ef4303b7b..b85338301f7218577e07ad01bfc4a5d356b56b54 100644
--- a/Source/core/svg/graphics/SVGImageChromeClient.cpp
+++ b/Source/core/svg/graphics/SVGImageChromeClient.cpp
@@ -63,6 +63,12 @@ void SVGImageChromeClient::invalidateContentsAndRootView(const IntRect& r)
void SVGImageChromeClient::scheduleAnimation()
{
+ // FIXME: This should not be called after chromeDestroyed, but
+ // crbug.com/350907 seems to indicate it can be. Adding this
+ // ASSERT until we have a LayoutTest to reproduce this!
+ ASSERT(m_image);
+ if (!m_image)
+ return;
// Because a single SVGImage can be shared by multiple pages, we can't key
// our svg image layout on the page's real animation frame. Therefore, we
// run this fake animation timer to trigger layout in SVGImages. The name,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698