Chromium: make use of new get_files_affected_by_patch.

Chromium: make use of new get_files_affected_by_patch.

This properly accounts for patch project to compute correct list of changed
files for decision making of analyze.py.

Context: https://codereview.chromium.org/1934533002/#msg19
Depends on: https://codereview.chromium.org/1927403003/

R=phajdan.jr@chromium.org,rmistry@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300397

[tandrii(chromium), 2016-04-29 15:05:38]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 15:05:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933223002/1

[tandrii(chromium), 2016-04-29 15:11:20]

PTAL

All expectation changes are just extra 'src' in step output of
tryserver.get_files_affected_by_patch + skia bot now running blink patch.

[commit-bot: I haz the power, 2016-04-29 15:13:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 15:13:40]

Dry run: Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[rmistry, 2016-04-29 16:40:44]

rmistry@google.com changed reviewers:
+ rmistry@google.com

[rmistry, 2016-04-29 16:40:45]

lgtm

https://codereview.chromium.org/1933223002/diff/1/scripts/slave/recipes/chrom...
File
scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json
(right):

https://codereview.chromium.org/1933223002/diff/1/scripts/slave/recipes/chrom...
scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json:235:
"cwd": "[SLAVE_BUILD]/src/third_party/skia",
This looks much better.

[Michael Achenbach, 2016-05-02 06:52:46]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-05-02 06:52:47]

lgtm

[Paweł Hajdan Jr., 2016-05-02 09:29:02]

https://codereview.chromium.org/1933223002/diff/1/scripts/slave/recipes/chrom...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/1933223002/diff/1/scripts/slave/recipes/chrom...
scripts/slave/recipes/chromium_trybot.py:91: def
_get_files_affected_by_patch(api):
Could you move this to chromium_tests recipe module, above analyze?

https://codereview.chromium.org/1933223002/diff/1/scripts/slave/recipes/chrom...
scripts/slave/recipes/chromium_trybot.py:98: # patch_root includes src and
affected_files are now relative to patch_root.
Can we make this more generic? When moved to chromium_tests it could become a
parameter, but maybe we can infer that from patch_root.

[tandrii(chromium), 2016-05-02 09:51:18]

Pawel, PTAL!

https://codereview.chromium.org/1933223002/diff/1/scripts/slave/recipes/chrom...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/1933223002/diff/1/scripts/slave/recipes/chrom...
scripts/slave/recipes/chromium_trybot.py:91: def
_get_files_affected_by_patch(api):
On 2016/05/02 09:29:02, Paweł Hajdan Jr. wrote:
> Could you move this to chromium_tests recipe module, above analyze?

Done.

https://codereview.chromium.org/1933223002/diff/1/scripts/slave/recipes/chrom...
scripts/slave/recipes/chromium_trybot.py:98: # patch_root includes src and
affected_files are now relative to patch_root.
On 2016/05/02 09:29:02, Paweł Hajdan Jr. wrote:
> Can we make this more generic? When moved to chromium_tests it could become a
> parameter, but maybe we can infer that from patch_root.
Hm, not quite sure I understood you, but see what I ended up with.

[tandrii(chromium), 2016-05-02 09:52:35]

also note: I've rebased depot_tools based on which I've generated expectations,
and that's why only skia's expectations changed, as they should.

[tandrii(chromium), 2016-05-02 11:40:13]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-05-02 11:40:13]

The patchset sent to the CQ was uploaded after l-g-t-m from rmistry@google.com,
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/1933223002/#ps20001
(title: "review")

[commit-bot: I haz the power, 2016-05-02 11:40:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933223002/20001

[commit-bot: I haz the power, 2016-05-02 11:44:22]

Description was changed from

==========
Chromium: make use of new get_files_affected_by_patch.

This properly accounts for patch project to compute correct list of changed
files for decision making of analyze.py.

Context: https://codereview.chromium.org/1934533002/#msg19
Depends on: https://codereview.chromium.org/1927403003/

R=phajdan.jr@chromium.org,rmistry@chromium.org
BUG=
==========

to

==========
Chromium: make use of new get_files_affected_by_patch.

This properly accounts for patch project to compute correct list of changed
files for decision making of analyze.py.

Context: https://codereview.chromium.org/1934533002/#msg19
Depends on: https://codereview.chromium.org/1927403003/

R=phajdan.jr@chromium.org,rmistry@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300397
==========

[commit-bot: I haz the power, 2016-05-02 11:44:23]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300397