Chromium: make use of new get_files_affected_by_patch.

scripts/slave/recipes/chromium_trybot.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 
 from recipe_engine.types import freeze
 
 DEPS = [
   'depot_tools/bot_update',
@@ skipping 70 matching lines @@
 
   return result
 
 
 def all_compile_targets(api, tests):
   """Returns the compile_targets for all the Tests in |tests|."""
   return sorted(set(x
                     for test in tests
                     for x in test.compile_targets(api)))
 
+def _get_files_affected_by_patch(api):

[Paweł Hajdan Jr., 2016/05/02 09:29:02]

Could you move this to chromium_tests recipe module, above analyze?

[tandrii(chromium), 2016/05/02 09:51:18]

Done.

+  """Returns list of posix paths relative to 'src'."""
+  patch_root = api.gclient.calculate_patch_root(
+      api.properties.get('patch_project'))
+  affected_files = map(str,
+      api.tryserver.get_files_affected_by_patch(patch_root))
+
+  # patch_root includes src and affected_files are now relative to patch_root.

[Paweł Hajdan Jr., 2016/05/02 09:29:02]

Can we make this more generic? When moved to chromium_tests it could become a
parameter, but maybe we can infer that from patch_root.

[tandrii(chromium), 2016/05/02 09:51:18]

Hm, not quite sure I understood you, but see what I ended up with.

+  # "analyze" wants these relative to 'src'.
+  assert str(patch_root).startswith('src')
+  for i, path in enumerate(affected_files):
+    assert path.startswith('src/')
+    affected_files[i] = path[len('src/'):]
+  return affected_files
+
 
 def is_source_file(api, filepath):
   """Returns true iff the file is a source file."""
   _, ext = api.path.splitext(filepath)
   return ext in ['.c', '.cc', '.cpp', '.h', '.java', '.mm']
 
 def _RunStepsInternal(api):
   def _get_bot_config(mastername, buildername):
     master_dict = api.chromium_tests.trybots.get(mastername, {})
     return master_dict.get('builders', {}).get(buildername)
@@ skipping 19 matching lines @@
 
   bot_update_step, bot_db = api.chromium_tests.prepare_checkout(
       bot_config_object)
 
   tests, tests_including_triggered = api.chromium_tests.get_tests(
       bot_config_object, bot_db)
   def add_tests(additional_tests):
     tests.extend(additional_tests)
     tests_including_triggered.extend(additional_tests)
 
-  affected_files = api.tryserver.get_files_affected_by_patch()
+  affected_files = _get_files_affected_by_patch(api)
 
   affects_blink_paths = False
   for path in CHROMIUM_BLINK_TESTS_PATHS:
     if any([f.startswith(path) for f in affected_files]):
       affects_blink_paths = True
 
   affects_blink = any([f.startswith('third_party/WebKit')
                        for f in affected_files])
 
   if affects_blink:
@@ skipping 755 matching lines @@
     props(mastername='tryserver.v8',
           buildername='v8_linux_blink_rel',
           patch_project='v8') +
     api.platform.name('linux') +
     suppress_analyze(more_exclusions=['v8/f.*']) +
     api.override_step_data('webkit_tests (with patch)',
         api.test_utils.canned_test_output(passing=False)) +
     api.override_step_data('webkit_tests (without patch)',
         api.test_utils.canned_test_output(passing=True, minimal=True))
   )