Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1933193002: Restructure LayoutSVGText::layout (Closed)

Created:
4 years, 7 months ago by fs
Modified:
4 years, 7 months ago
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restructure LayoutSVGText::layout "Uncascade" LayoutSVGText::layout by separating the handling of the two flags (m_needsTextMetricsUpdate, m_needsPositioningValuesUpdate) into sequential blocks. Add assert to verify consistency. BUG=607906 Committed: https://crrev.com/731c92d1821ff04b324eb334f484337005d713c9 Cr-Commit-Position: refs/heads/master@{#390691}

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -33 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 2 chunks +31 lines, -33 lines 8 comments Download

Messages

Total messages: 13 (6 generated)
fs
4 years, 7 months ago (2016-04-29 13:45:04 UTC) #5
Stephen Chennney
lgtm
4 years, 7 months ago (2016-04-29 17:40:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933193002/1
4 years, 7 months ago (2016-04-29 17:41:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 17:45:49 UTC) #9
f(malita)
LGTM (belated) with some nits - feel free to ignore or address in other CLs ...
4 years, 7 months ago (2016-04-29 17:50:54 UTC) #10
fs
On 2016/04/29 at 17:50:54, fmalita wrote: > LGTM (belated) with some nits - feel free ...
4 years, 7 months ago (2016-04-29 19:43:26 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:26:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/731c92d1821ff04b324eb334f484337005d713c9
Cr-Commit-Position: refs/heads/master@{#390691}

Powered by Google App Engine
This is Rietveld 408576698