Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1933413002: Minor tweaks to m_needsReordering in LayoutSVGText::layout (Closed)

Created:
4 years, 7 months ago by fs
Modified:
4 years, 7 months ago
Reviewers:
f(malita)
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor tweaks to m_needsReordering in LayoutSVGText::layout Nit fixes from https://codereview.chromium.org/1933193002/. BUG=607906 Committed: https://crrev.com/312abc7136a25ea6fc67504d07faa6e3c71dab1c Cr-Commit-Position: refs/heads/master@{#390753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 7 months ago (2016-04-29 19:43:49 UTC) #2
f(malita)
lgtm
4 years, 7 months ago (2016-04-29 20:18:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933413002/1
4 years, 7 months ago (2016-04-29 20:48:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 20:56:54 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:28:45 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/312abc7136a25ea6fc67504d07faa6e3c71dab1c
Cr-Commit-Position: refs/heads/master@{#390753}

Powered by Google App Engine
This is Rietveld 408576698